Skip to content

Commit

Permalink
Fix getDevSupportManager() in ReactDelegate
Browse files Browse the repository at this point in the history
Summary:
In facebook#43520, this was moved to supply with the relevant DevSupportManager, however this check for `useDeveloperSupport` is already part of https://github.com/facebook/react-native/blob/0.74-stable/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/ReactInstanceManager.java#L263

https://github.com/facebook/react-native/blob/0.74-stable/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/DefaultDevSupportManagerFactory.java#L68-L70

Having this check here was causing early exit for Bridge RELEASE mode instead of returning the ReleaseDevSupportManager.

Changelog:
[ANDROID][FIXED] - Fixed `getDevSupportManager()` in ReactDelegate

Reviewed By: javache

Differential Revision: D56739764
  • Loading branch information
arushikesarwani94 authored and facebook-github-bot committed Apr 30, 2024
1 parent c96c893 commit c942d71
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ private DevSupportManager getDevSupportManager() {
&& mReactHost.getDevSupportManager() != null) {
return mReactHost.getDevSupportManager();
} else if (getReactNativeHost().hasInstance()
&& getReactNativeHost().getUseDeveloperSupport()) {
&& getReactNativeHost().getReactInstanceManager() != null) {
return getReactNativeHost().getReactInstanceManager().getDevSupportManager();
} else {
return null;
Expand Down

0 comments on commit c942d71

Please sign in to comment.