-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add khat and ps_min_ss #20
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OriolAbril
reviewed
Sep 14, 2024
OriolAbril
approved these changes
Sep 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's merge this first, then rebase the 1d ess PR on top of that and add support for 1d arrays to ess/mcse/pareto_min_ss everywhere in that PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a placeholder, the goal is to eventually have a function to compute the
min_ss
as discussed here. The original implementation is here. There a lot of other functions implemented (also discussed in the vignette from the first link), I think we don't want those other functions, at least not now.I checked that I am getting the same result as in the vignette (to be sure I installed the Posterior package, I got the value of mu and converted it into a DataArray)
This is an example of how to run the function, first compute the k-hat and then the min_ss
Notice that a lot of this code overlaps with the code necessary to compute the pareto smoothing part of the PSIS-CV-LOO method (notice the "log_weights" argument in the code in this PR). So eventually we will need to use some of this code for LOO too.
📚 Documentation preview 📚: https://arviz-stats--20.org.readthedocs.build/en/20/