New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove query_params explicity conversion to dict #127

Open

umr55766 wants to merge 1 commit into aschn:master from umr55766:patch-2

Contributor

umr55766 commented Nov 13, 2018

This explicit conversion to dict is dropping all the values with same key
This is already being done in line 169

drf-tracking/rest_framework_tracking/base_mixins.py

Line 169 in 57344c6

data = dict(data)
Fixes Only last params value is captured if multiple query params are sent with same key #126


          Remove query_params explicity conversion to dict

1e1fd6c

- This explicit conversion to dict is dropping all the values with same key
- This is already being done in line 169 https://github.com/aschn/drf-tracking/blob/57344c65fe39923ab2debbf581d9fd0dbc46b2fa/rest_framework_tracking/base_mixins.py#L169
- Fixes aschn#126

Collaborator

avelis commented Nov 13, 2018

@umr55766 Can you address the failing tests before I take a look?

simone6021 commented Feb 7, 2019 •

edited

Loading

@umr55766, i looked into failing tests and i think they should include client calls with different content_type:

'multipart' (default in drf tests) which will return lists
'json' which is expected to have single string values

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet