add text resources for context menus

aschuhardt · Jun 4, 2023 · 0abf0e8 · 0abf0e8
1 parent 025a6ef
commit 0abf0e8
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 3 deletions.
diff --git a/Resources/Localization/Text.Designer.cs b/Resources/Localization/Text.Designer.cs
diff --git a/Resources/Localization/Text.resx b/Resources/Localization/Text.resx
@@ -383,4 +383,10 @@
 	<data name="SettingsPage_HidePullTab" xml:space="preserve">
 		<value>Hide menu pull tab</value>
 	</data>
+	<data name="BrowserView_BuildContextMenu_Copy_URL" xml:space="preserve">
+		<value>Copy URL</value>
+	</data>
+	<data name="BrowserView_BuildContextMenu_Share_URL" xml:space="preserve">
+		<value>Share URL</value>
+	</data>
 </root>
diff --git a/Views/BrowserView.xaml.cs b/Views/BrowserView.xaml.cs
@@ -933,17 +933,17 @@ protected virtual void OnClearFindNext()
 
 
 #if ANDROID
-    private void BuildContextMenu(IContextMenu menu, Android.Webkit.WebView view)
+    private static void BuildContextMenu(IMenu menu, Android.Webkit.WebView view)
     {
         var hitTest = view.GetHitTestResult();
 
         if (hitTest.Type is HitTestResult.AnchorType or HitTestResult.SrcAnchorType or HitTestResult.SrcImageAnchorType &&
             !string.IsNullOrWhiteSpace(hitTest.Extra))
         {
-            menu.Add("Copy URL")?.SetOnMenuItemClickListener(
+            menu.Add(Text.BrowserView_BuildContextMenu_Copy_URL)?.SetOnMenuItemClickListener(
                 new ActionMenuClickHandler<string>(hitTest.Extra,
                     async uri => await Clipboard.Default.SetTextAsync(uri)));
-            menu.Add("Share URL")?.SetOnMenuItemClickListener(
+            menu.Add(Text.BrowserView_BuildContextMenu_Share_URL)?.SetOnMenuItemClickListener(
                 new ActionMenuClickHandler<string>(hitTest.Extra,
                     async uri => await Share.Default.RequestAsync(new ShareTextRequest(uri))));
         }