Support Java 11 (rebased) #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Also update Java dependency to Java 11, and update all Maven plugins to the latest version. Also add a requirement that the Maven version must be at least 3.0.5 in order to support the latest plugins. Modularise and get things compiling on Java 11. The StandardAdapter was trashed in the process, though. License headers are not javadocs. First draft of getting the asciidoclet to run on the new Javadoc APIs under Java 11. Many things are broken. This is currently more of an exploratory prototype, than it is working but incomplete code. There are a lot of ugly hacks here, to work around the new restrictions of the javadoc APIs. Tell Travis CI to use Java 11. Bring back error reporting in AttributesLoader, and make sure to always close the attributes files we open. Make the stylesheet tests pass. Also update Stylesheets to use new Java APIs, and make sure that input and output streams are closed. Insert asciidoctor rendering into more places. Doclet option names begin with double-dashes. Also make sure that the output directory of the integration test is empty before rendering new doclet output. The old AsciidocletTest is not worth salvaging. Reduce reliance on Guava for IO stuff. Remove the remaining usages of Guava. Improve the javadoc parsing. Particularly around javadoc tags. Also avoid re-rendering asciidoctor javadoc comments that have already been rendered. Fix tests and remove debugging left overs. Keep everything grouped under the `org.asciidctor.asciidoclet` group and package. Fix the Maven javadoc plugin configuration, and a couple of other things, to almost make it possible for asciidoclet to render its own javadoc. Resource copying, including copying over our own style sheets, now works again. Make a `mvn javadoc:javadoc` build pass, by ignoring HTML5 doclint errors. Overview, and other files, are now processed correctly as well. Included in this is also a bunch of cleanup. Particularly, many inner classes have been extracted. Reported javadoc errors are now also _slightly_ closer to their cause in the code. Add callouts to explain the new options in the Maven plugin example.
abelsromero
force-pushed
the
java11-rebased
branch
6 times, most recently
from
895700d
to
3262ae2
Compare
Fix http refences for https Add missing attributes test and fix attributes_long treatment Add missing -include and -exclude options to Antora docs + review some cleanup Fix Javadoc generation + sdkmanrc Refactor JavadocParser to use factory method for readability * rename some render references Update javadoc-usage references Fix templates not being found in unit tests Replace AsciidocletIntegrationTest (did not work in IntelliJ) by end-to-end test with maven-invoker-plugin update .gitignore Remove un-used overview from DocletOptions.java Delete DocIterator cleanup docs
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merits for @chrisvest and the work in #96. The short version; I rebased the branch on the most recent branch, made sure tests work and did some exploratory testing .
On top of rebase, there are these changes:
@asciidocletfilter Added Asciidoc processing class filtering to allow for graceful migrations #91. The way it works now is that the contents always pass to the default Javadoc converter so this is not necessary to do progressive transitions.AsciidoctorRenderertoAsciidoctorConverterfor follow recent Asciidoctor naming.These is NOT include and is not in scope of the PR:
2.0.0milestone to organize the release.