Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Usage docs #135

Merged

Conversation

abelsromero
Copy link
Member

@abelsromero abelsromero commented Apr 20, 2024

  • Update Antora properties for v2.0.0
  • Update usage with Maven Java 11 and 17+ examples
  • Update usage with Gradle Java 11 and 17+ examples
  • Remove Ant example. Given my experience trying to get it to work, I cannot recommend it. Most examples online don't work and are years old. Even if only for Javadoc I'd suggest anyone to set up Maven or Gradle nowadays.
  • Update ITs to align with the examples.
  • Replace incorrect "Asciidoc" mentioned by "AsciiDoc" in docs

Closes #127

@abelsromero abelsromero force-pushed the issue-127/main/document-opens branch from f5016b4 to 0e71d13 Compare April 20, 2024 20:07
@abelsromero abelsromero marked this pull request as ready for review April 20, 2024 21:17
@abelsromero
Copy link
Member Author

@dakusui I'd appreciate if you could have a look at the updated examples 🙏 I tested several times and the ITs (with maven-invoker-plugin) are green in the GitHub actions. But I found it odd that Java 11 only requires 1 "exports", can you confirm this from your side?

@dakusui
Copy link
Contributor

dakusui commented Apr 20, 2024

Alright.
I'll do it today or tomorrow.

@abelsromero
Copy link
Member Author

No rush really

dakusui pushed a commit to dakusui/java-17-21-template that referenced this pull request Apr 22, 2024
dakusui pushed a commit to dakusui/java-17-21-template that referenced this pull request Apr 22, 2024
- Requested by this comment: asciidoctor/asciidoclet#135 (comment)
- Add java-version.txt to record java version with which the test was executed.
dakusui pushed a commit to dakusui/java-17-21-template that referenced this pull request Apr 22, 2024
- Requested by this comment: asciidoctor/asciidoclet#135 (comment)
- Add java-version.txt to record java version with which the test was executed.
@dakusui
Copy link
Contributor

dakusui commented Apr 22, 2024

Both of them seem to work.

Please check the elements in pom.xmls and image.pngs at the top directory.
I only needed to change the version string to meet maven's usual convention.

@abelsromero
Copy link
Member Author

Thanks! I'll have a final triple-check and if all is well (which seems), merge and start thinking about the release.

@abelsromero abelsromero merged commit a398158 into asciidoctor:main Apr 24, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add clear documentation to configure opens for the different java versions
2 participants