-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make plugin compatible with maven-site-plugin 4.0.0-M1 #585
Merged
abelsromero
merged 1 commit into
asciidoctor:main
from
abelsromero:bump-doxia-to-2.0.0-M2
Jun 12, 2022
Merged
Make plugin compatible with maven-site-plugin 4.0.0-M1 #585
abelsromero
merged 1 commit into
asciidoctor:main
from
abelsromero:bump-doxia-to-2.0.0-M2
Jun 12, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I am being minimalistic here, to avoid releasing changes in docs we'd need to create a 2.2.x branch and update docs.asciidoctor.org playbook, I just commented them out and updated by release guide with a note. |
abelsromero
force-pushed
the
bump-doxia-to-2.0.0-M2
branch
2 times, most recently
from
June 12, 2022 16:47
898b663
to
6c046eb
Compare
* Bump Doxia to 2.0.0-M1 * Leave note in docs for release * Use SLF4J in site module (apache/maven-doxia#5) * Reorder constructor args in AsciidoctorDoxiaParserModule * Update IT test site.xml Fixes asciidoctor#578
abelsromero
force-pushed
the
bump-doxia-to-2.0.0-M2
branch
from
June 12, 2022 17:44
6c046eb
to
fd1b3b5
Compare
abelsromero
added a commit
that referenced
this pull request
Aug 25, 2022
* Bump Doxia to 2.0.0-M1 * Leave note in docs for release * Use SLF4J in site module (apache/maven-doxia#5) * Reorder constructor args in AsciidoctorDoxiaParserModule * Update IT test site.xml Fixes #578
abelsromero
added a commit
that referenced
this pull request
Aug 25, 2022
* Bump Doxia to 2.0.0-M1 * Leave note in docs for release * Use SLF4J in site module (apache/maven-doxia#5) * Reorder constructor args in AsciidoctorDoxiaParserModule * Update IT test site.xml Fixes #578
abelsromero
added a commit
to abelsromero/asciidoctor-maven-plugin
that referenced
this pull request
Aug 28, 2022
* Bump Doxia to 2.0.0-M1 * Leave note in docs for release * Use SLF4J in site module (apache/maven-doxia#5) * Reorder constructor args in AsciidoctorDoxiaParserModule * Update IT test site.xml Fixes asciidoctor#578
abelsromero
added a commit
to abelsromero/asciidoctor-maven-plugin
that referenced
this pull request
Oct 17, 2022
* Bump Doxia to 2.0.0-M1 * Leave note in docs for release * Use SLF4J in site module (apache/maven-doxia#5) * Reorder constructor args in AsciidoctorDoxiaParserModule * Update IT test site.xml Fixes asciidoctor#578
abelsromero
added a commit
to abelsromero/asciidoctor-maven-plugin
that referenced
this pull request
May 8, 2023
* Bump Doxia to 2.0.0-M1 * Leave note in docs for release * Use SLF4J in site module (apache/maven-doxia#5) * Reorder constructor args in AsciidoctorDoxiaParserModule * Update IT test site.xml Fixes asciidoctor#578
abelsromero
added a commit
to abelsromero/asciidoctor-maven-plugin
that referenced
this pull request
Dec 27, 2023
* Bump Doxia to 2.0.0-M1 * Leave note in docs for release * Use SLF4J in site module (apache/maven-doxia#5) * Reorder constructor args in AsciidoctorDoxiaParserModule * Update IT test site.xml Fixes asciidoctor#578
abelsromero
added a commit
to abelsromero/asciidoctor-maven-plugin
that referenced
this pull request
Dec 29, 2023
* Bump Doxia to 2.0.0-M1 * Leave note in docs for release * Use SLF4J in site module (apache/maven-doxia#5) * Reorder constructor args in AsciidoctorDoxiaParserModule * Update IT test site.xml Fixes asciidoctor#578
abelsromero
added a commit
to abelsromero/asciidoctor-maven-plugin
that referenced
this pull request
Jan 13, 2024
* Bump Doxia to 2.0.0-M1 * Leave note in docs for release * Use SLF4J in site module (apache/maven-doxia#5) * Reorder constructor args in AsciidoctorDoxiaParserModule * Update IT test site.xml Fixes asciidoctor#578 Bump doxia-core to v2.0.0-M3 (asciidoctor#590) * Bump maven-site-plugin in IT to v4.0.0-M3 * Add skin to IT (mandatory since v4.0.0-M2) Bump maven-site and doxia to latests * maven-site-plugin v4.0.0-M8 * doxia & fluido skin 2.0.0-M6 * Sections and tables updated Bump maven-site to M13, Doxia to M8
abelsromero
added a commit
to abelsromero/asciidoctor-maven-plugin
that referenced
this pull request
Jan 13, 2024
* Bump Doxia to 2.0.0-M1 * Leave note in docs for release * Use SLF4J in site module (apache/maven-doxia#5) * Reorder constructor args in AsciidoctorDoxiaParserModule * Update IT test site.xml Fixes asciidoctor#578 Bump doxia-core to v2.0.0-M3 (asciidoctor#590) * Bump maven-site-plugin in IT to v4.0.0-M3 * Add skin to IT (mandatory since v4.0.0-M2) Bump maven-site and doxia to latests * maven-site-plugin v4.0.0-M8 * doxia & fluido skin 2.0.0-M6 * Sections and tables updated Bump maven-site to M13, Doxia to M8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #578
What kind of change does this PR introduce? (check at least one)
What is the goal of this pull request?
Make the site module compatible with latest maven-site-plugin 4.0.0-M1.
Are there any alternative ways to implement this?
No. Basic process is just bumping Doxia and updating required changes.
Are there any implications of this pull request? Anything a user must know?
maven-site-plugin v3.1x.x is still compatible. So in case of need we can still do a 2.2.3 release without breaking builds.
Is it related to an existing issue?
Finally, please add a corresponding entry to CHANGELOG.adoc