Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make plugin compatible with maven-site-plugin 4.0.0-M1 #585

Merged
merged 1 commit into from
Jun 12, 2022

Conversation

abelsromero
Copy link
Member

@abelsromero abelsromero commented Jun 12, 2022

Fixes #578

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Documentation
  • Refactor
  • Build improvement
  • Other (please describe)

What is the goal of this pull request?
Make the site module compatible with latest maven-site-plugin 4.0.0-M1.

Are there any alternative ways to implement this?
No. Basic process is just bumping Doxia and updating required changes.

Are there any implications of this pull request? Anything a user must know?
maven-site-plugin v3.1x.x is still compatible. So in case of need we can still do a 2.2.3 release without breaking builds.

Is it related to an existing issue?

  • Yes
  • No

Finally, please add a corresponding entry to CHANGELOG.adoc

@abelsromero
Copy link
Member Author

I am being minimalistic here, to avoid releasing changes in docs we'd need to create a 2.2.x branch and update docs.asciidoctor.org playbook, I just commented them out and updated by release guide with a note.

@abelsromero abelsromero force-pushed the bump-doxia-to-2.0.0-M2 branch 2 times, most recently from 898b663 to 6c046eb Compare June 12, 2022 16:47
* Bump Doxia to 2.0.0-M1
* Leave note in docs for release
* Use SLF4J in site module (apache/maven-doxia#5)
* Reorder constructor args in AsciidoctorDoxiaParserModule
* Update IT test site.xml

Fixes asciidoctor#578
@abelsromero abelsromero force-pushed the bump-doxia-to-2.0.0-M2 branch from 6c046eb to fd1b3b5 Compare June 12, 2022 17:44
@abelsromero abelsromero merged commit f76071a into asciidoctor:main Jun 12, 2022
abelsromero added a commit that referenced this pull request Aug 25, 2022
* Bump Doxia to 2.0.0-M1
* Leave note in docs for release
* Use SLF4J in site module (apache/maven-doxia#5)
* Reorder constructor args in AsciidoctorDoxiaParserModule
* Update IT test site.xml

Fixes #578
abelsromero added a commit that referenced this pull request Aug 25, 2022
* Bump Doxia to 2.0.0-M1
* Leave note in docs for release
* Use SLF4J in site module (apache/maven-doxia#5)
* Reorder constructor args in AsciidoctorDoxiaParserModule
* Update IT test site.xml

Fixes #578
abelsromero added a commit to abelsromero/asciidoctor-maven-plugin that referenced this pull request Aug 28, 2022
* Bump Doxia to 2.0.0-M1
* Leave note in docs for release
* Use SLF4J in site module (apache/maven-doxia#5)
* Reorder constructor args in AsciidoctorDoxiaParserModule
* Update IT test site.xml

Fixes asciidoctor#578
abelsromero added a commit to abelsromero/asciidoctor-maven-plugin that referenced this pull request Oct 17, 2022
* Bump Doxia to 2.0.0-M1
* Leave note in docs for release
* Use SLF4J in site module (apache/maven-doxia#5)
* Reorder constructor args in AsciidoctorDoxiaParserModule
* Update IT test site.xml

Fixes asciidoctor#578
@abelsromero abelsromero deleted the bump-doxia-to-2.0.0-M2 branch March 18, 2023 20:12
abelsromero added a commit to abelsromero/asciidoctor-maven-plugin that referenced this pull request May 8, 2023
* Bump Doxia to 2.0.0-M1
* Leave note in docs for release
* Use SLF4J in site module (apache/maven-doxia#5)
* Reorder constructor args in AsciidoctorDoxiaParserModule
* Update IT test site.xml

Fixes asciidoctor#578
abelsromero added a commit to abelsromero/asciidoctor-maven-plugin that referenced this pull request Dec 27, 2023
* Bump Doxia to 2.0.0-M1
* Leave note in docs for release
* Use SLF4J in site module (apache/maven-doxia#5)
* Reorder constructor args in AsciidoctorDoxiaParserModule
* Update IT test site.xml

Fixes asciidoctor#578
abelsromero added a commit to abelsromero/asciidoctor-maven-plugin that referenced this pull request Dec 29, 2023
* Bump Doxia to 2.0.0-M1
* Leave note in docs for release
* Use SLF4J in site module (apache/maven-doxia#5)
* Reorder constructor args in AsciidoctorDoxiaParserModule
* Update IT test site.xml

Fixes asciidoctor#578
abelsromero added a commit to abelsromero/asciidoctor-maven-plugin that referenced this pull request Jan 13, 2024
* Bump Doxia to 2.0.0-M1
* Leave note in docs for release
* Use SLF4J in site module (apache/maven-doxia#5)
* Reorder constructor args in AsciidoctorDoxiaParserModule
* Update IT test site.xml

Fixes asciidoctor#578

Bump doxia-core to v2.0.0-M3 (asciidoctor#590)

* Bump maven-site-plugin in IT to v4.0.0-M3
* Add skin to IT (mandatory since v4.0.0-M2)

Bump maven-site and doxia to latests

* maven-site-plugin v4.0.0-M8
* doxia & fluido skin 2.0.0-M6
* Sections and tables updated

Bump maven-site to M13, Doxia to M8
abelsromero added a commit to abelsromero/asciidoctor-maven-plugin that referenced this pull request Jan 13, 2024
* Bump Doxia to 2.0.0-M1
* Leave note in docs for release
* Use SLF4J in site module (apache/maven-doxia#5)
* Reorder constructor args in AsciidoctorDoxiaParserModule
* Update IT test site.xml

Fixes asciidoctor#578

Bump doxia-core to v2.0.0-M3 (asciidoctor#590)

* Bump maven-site-plugin in IT to v4.0.0-M3
* Add skin to IT (mandatory since v4.0.0-M2)

Bump maven-site and doxia to latests

* maven-site-plugin v4.0.0-M8
* doxia & fluido skin 2.0.0-M6
* Sections and tables updated

Bump maven-site to M13, Doxia to M8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Apache Maven Site Plugin Version 4.0.0-MX
1 participant