resolves #2430 remove null character enclosed by XML tag when sanitiz…

…ing text (PR #2431)

CHANGELOG.adoc

@@ -40,6 +40,7 @@ Improvements::
 
 Bug Fixes::
 
+* remove null character enclosed in XML tag when santizing text; fixes invisible text in outline when heading contains index term (#2430)
 * correctly map all icons from FontAwesome 4 (#2373)
 * resolve remote image in document title or section title with autogenerated ID
 * keep caret between items in menu macro with previous item if items wrap

lib/asciidoctor/pdf/sanitizer.rb

@@ -19,11 +19,11 @@ module Sanitizer
         'nbsp' => ' ',
         'quot' => '"',
       }).default = '?'
-      SanitizeXMLRx = /<[^>]+>/
+      SanitizeXMLRx = /<[^>]+>\0?/
       CharRefRx = /&(?:amp;)?(?:([a-z][a-z]+\d{0,2})|#(?:(\d\d\d{0,4})|x(\h\h\h{0,3})));/
       UnescapedAmpersandRx = /&(?!(?:[a-z][a-z]+\d{0,2}|#(?:\d\d\d{0,4}|x\h\h\h{0,3}));)/
 
-      # Strip leading, trailing and repeating whitespace, remove XML tags and
+      # Strip leading, trailing and repeating whitespace, remove XML tags along with an enclosed null character, and
       # resolve all entities in the specified string.
       #
       # FIXME: move to a module so we can mix it in elsewhere

spec/outline_spec.rb

@@ -768,14 +768,18 @@
       pdf = to_pdf <<~'END'
       = _Document_ *Title*
       :doctype: book
+      :sectnums:
 
       == _First_ *Chapter*
+
+      == ((Wetland Birds))
       END
 
       outline = extract_outline pdf
-      (expect outline).to have_size 2
+      (expect outline).to have_size 3
       (expect outline[0][:title]).to eql 'Document Title'
-      (expect outline[1][:title]).to eql 'First Chapter'
+      (expect outline[1][:title]).to eql 'Chapter 1. First Chapter'
+      (expect outline[2][:title]).to eql 'Chapter 2. Wetland Birds'
     end
 
     it 'should decode character references in entries' do