Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update schemas for ASDF standard 1.6.0 #59

Merged
merged 10 commits into from
Mar 9, 2024
Merged

Update schemas for ASDF standard 1.6.0 #59

merged 10 commits into from
Mar 9, 2024

Conversation

braingram
Copy link
Contributor

No description provided.

@braingram braingram mentioned this pull request Feb 7, 2024
Open
25 tasks
@braingram braingram changed the title TEST: update for 1.6.0 standard Update schemas for ASDF standard 1.6.0 Feb 20, 2024
@braingram braingram marked this pull request as ready for review February 20, 2024 14:28
@braingram braingram closed this Feb 20, 2024
@braingram braingram reopened this Feb 20, 2024
braingram
braingram commented Feb 20, 2024
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
braingram
braingram commented Feb 20, 2024
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
nden
nden approved these changes Feb 24, 2024
View reviewed changes
Copy link
Contributor

@nden nden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@braingram braingram force-pushed the standard_1p6p0 branch 2 times, most recently from e096e3e to cb7c584 Compare March 6, 2024 19:16
@braingram
Copy link
Contributor Author

braingram commented Mar 6, 2024 •
edited
Loading

I missed this until now but the $ref here (on main):

asdf-wcs-schemas/resources/schemas/stsci.edu/gwcs/frame-1.0.0.yaml

Line 62 in 4d01f27

$ref: "http://astropy.org/schemas/astropy/coordinates/frames/baseframe-1.0.0"

means that this package should depend on asdf-coordinates-schemas (it already depends on asdf-transform-schemas).

I added asdf-coordinates-schemas as a dependency and I think that slightly changes the plans for release to be:

@braingram braingram force-pushed the standard_1p6p0 branch 2 times, most recently from 9987a09 to e593610 Compare March 9, 2024 16:55
@braingram braingram merged commit 90209e3 into asdf-format:main Mar 9, 2024
11 checks passed
@braingram braingram deleted the standard_1p6p0 branch March 9, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nden nden nden approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@braingram @nden