-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated code #1852
Remove deprecated code #1852
Conversation
a2e1c7e
to
06b45e9
Compare
89b59c9
to
048fb06
Compare
048fb06
to
3e63541
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, assuming the weldex failure is not an issue.
Thanks! There is a PR that fixes the error: I may open a smaller one that's just that error since the above PR also has schema changes (although those are required for #1744). |
Description
This PR removes deprecated API. See docs link below for more details.
Closes #1698
Closes #1859
It needs:
The major changes to make sure to note are:
$ref
will no longer resolveresolve_references
is no longer called forAsdfFile.__init__
orasdf.open
Checklist:
pre-commit checks ran successfully
tests ran successfully
for a public change, added a towncrier news fragment
changes/<PR#>.<changetype>.rst
changes/<PR#>.feature.rst
: new featurechanges/<PR#>.bugfix.rst
: bug fixchanges/<PR#>.doc.rst
: documentation changechanges/<PR#>.removal.rst
: deprecation or removal of public APIchanges/<PR#>.general.rst
: infrastructure or miscellaneous changefor a public change, updated documentation
for any new features, unit tests were added