Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Facilitate json serialization, export bufbuild helpers #106

Merged
merged 5 commits into from
Dec 13, 2024
Merged

Facilitate json serialization, export bufbuild helpers #106

merged 5 commits into from
Dec 13, 2024

Conversation

gimmyxd
Copy link
Member

@gimmyxd gimmyxd commented Dec 9, 2024 •
edited
Loading

  • added toJSON to all the directory v3 response
    • for the import/ex port the method needs to be async as the response is an asyncIterable.
  • added express integration tests.
  • expose @bufbuild/protobuf as a fallback when more advanced use-cases are needed and one would need to manually serialize the data

@gimmyxd gimmyxd requested a review from ogazitt December 9, 2024 14:04
@gimmyxd gimmyxd changed the title export bufbuild helpers Facilitate json serialization, export bufbuild helpers Dec 10, 2024
@gimmyxd gimmyxd merged commit 45ff471 into main Dec 13, 2024
5 checks passed
@gimmyxd gimmyxd deleted the protobuf_helpers branch December 13, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carabasdaniel carabasdaniel carabasdaniel approved these changes

@ogazitt ogazitt Awaiting requested review from ogazitt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gimmyxd @carabasdaniel