Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use protojson & default instance_label to policy_name #69

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

gertd
Copy link
Member

@gertd gertd commented Aug 14, 2024

The aserto dl stream command uses JSON marshal instead of protojson resulting in:

"timestamp": {
    "seconds": 1723586632,
    "nanos": 713391185
  }

instead of:

"timestamp":  "2024-08-13T23:14:18.752872404Z"

enums as numbers instead of enum names

    "context": {
      "identity": "[email protected]",
      "type": 2
    },

instead of:

"context":  {
      "identity":  "[email protected]",
      "type":  "IDENTITY_TYPE_SUB"
    }

When instance_label is not provided, the policy_name is used.

if cmd.InstanceLabel == "" && cmd.PolicyName != "" {
		cmd.InstanceLabel = cmd.PolicyName
	}

@gertd gertd requested a review from carabasdaniel August 14, 2024 14:54
@carabasdaniel carabasdaniel merged commit 20f231b into main Aug 14, 2024
3 checks passed
@carabasdaniel carabasdaniel deleted the fix-dl-stream branch August 14, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants