add missing (subject) relation checks

aserto-dev · Jul 30, 2024 · 7e8c5ea · 7e8c5ea
1 parent 2654cdd
commit 7e8c5ea
Showing 1 changed file with 10 additions and 0 deletions.
diff --git a/safe/relation.go b/safe/relation.go
@@ -99,6 +99,16 @@ func (i *SafeRelation) Validate(mc *cache.Cache) error {
 		return nil
 	}
 
+	if !mc.RelationExists(model.ObjectName(i.GetObjectType()), model.RelationName(i.GetRelation())) {
+		return derr.ErrRelationNotFound.Msg(i.GetObjectType() + ":" + i.GetRelation())
+	}
+
+	if IsSet(i.GetSubjectRelation()) {
+		if !mc.RelationExists(model.ObjectName(i.GetSubjectType()), model.RelationName(i.GetSubjectRelation())) {
+			return derr.ErrRelationNotFound.Msg(i.GetSubjectType() + ":" + i.GetSubjectRelation())
+		}
+	}
+
 	return mc.ValidateRelation(i.Relation)
 }