Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix loading empty manifest #16

Merged
merged 1 commit into from
Nov 13, 2023
Merged

fix loading empty manifest #16

merged 1 commit into from
Nov 13, 2023

Conversation

gertd
Copy link
Member

@gertd gertd commented Nov 13, 2023

When Decode of the manifest fails with an error == io.EOF, return an empty model instance instead of passing on the io.EOF error

@gertd gertd requested a review from ronenh November 13, 2023 21:47
@github-actions GitHub Actions
Copy link

Pull Request Test Coverage Report for Build 6856113850

  • 8 of 10 (80.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 51.441%
Changes Missing Coverage Covered Lines Changed/Added Lines %
v2/load.go 4 5 80.0%
v3/load.go 4 5 80.0%
Totals Coverage Status
Change from base Build 6751432567: 0.3%
Covered Lines: 696
Relevant Lines: 1353
💛 - Coveralls

@gertd gertd merged commit 4bd1103 into main Nov 13, 2023
2 checks passed
@gertd gertd deleted the fix-load-empty-manifest branch November 13, 2023 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronenh ronenh ronenh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gertd @ronenh