Fix GetGraph bug #54
Merged
Fix GetGraph bug #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a model-inversion bug. Given:
```yaml
folder:
relations:
owner: user
permissions:
is_owner: owner | parent->is_owner
doc:
relations:
parent: folder
viewer: user | user:* | group#member
permissions:
can_view: viewer | parent->owner
```
The `can_view` premission isn't inverted correctly.
A `group#member` can have the `can_view` permission, but only
through the first term (`viewer`) because `parent-owner` can only
be a `user`.
The problem is that the inversion logic attempts to create the inversion
of `parent->owner` on `group`
(i.e. `group#doc^can_view#member: doc_viewer#member | doc_owner#doc_parent`)
But `group` has no `doc_owner` relation because `group#member` isn't assignable
to`folder#owner`.
Pull Request Test Coverage Report for Build 10658163919Details
💛 - Coveralls |
gertd
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a model-inversion bug.
Given:
The
can_viewpremission isn't inverted correctly. Agroup#membercan have thecan_viewpermission, but only through the first term (viewer) becauseparent->is_ownercan only be auser.The problem is that the inversion logic attempts to create the inversion of
parent->ownerongroup(i.e.
group#doc^can_view#member: doc_viewer#member | doc_owner#doc_parent) Butgrouphas nodoc_ownerrelation becausegroup#memberisn't assignable tofolder#owner.