Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

relpool change + RelationId refectoring #62

Merged
merged 8 commits into from
Dec 11, 2024
Merged

relpool change + RelationId refectoring #62

merged 8 commits into from
Dec 11, 2024

Conversation

gertd
Copy link
Member

@gertd gertd commented Dec 10, 2024

No description provided.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12250486043

Details

  • 123 of 154 (79.87%) changed or added relevant lines in 11 files are covered.
  • 3 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.5%) to 66.457%

Changes Missing Coverage Covered Lines Changed/Added Lines %
graph/objects.go 10 11 90.91%
model/model.go 0 1 0.0%
mempool/relation.go 14 16 87.5%
mempool/mempool.go 38 41 92.68%
cache/check.go 0 6 0.0%
safe/relation.go 0 7 0.0%
cache/cache.go 6 17 35.29%
Files with Coverage Reduction New Missed Lines %
model/model.go 1 36.27%
graph/check.go 1 83.49%
graph/objects.go 1 89.04%
Totals Coverage Status
Change from base Build 12018348225: 0.5%
Covered Lines: 2639
Relevant Lines: 3971

💛 - Coveralls

@ronenh ronenh changed the base branch from main to relpool December 10, 2024 13:06
@gertd gertd marked this pull request as ready for review December 11, 2024 13:53
@gertd gertd requested a review from ronenh December 11, 2024 13:53
@gertd gertd merged commit 58c42fb into relpool Dec 11, 2024
1 check passed
@gertd gertd deleted the relpool-rid branch December 11, 2024 13:57
gertd added a commit that referenced this pull request Dec 11, 2024
* cache inverted model on first use

* write message when inverted model is cached

* Use sync.Pool for Relation slices. (#60)

* up go.sum

* Memory pool for slices and messages

* Add memory pool for timestamppb.Timestamp

* Use vtproto mempool for Relation

* relpool change + RelationId refectoring (#62)

* convert azm to use RelationIdentifier

* update go-directory & grpc deps

* Fix: Checker.checkRelation wasn't setting the subject ID

As a result it was getting way more relations back.

* update deps

* Toggle between shared or per-call memory pool.

* Replace Cache RWMutex with an atomic pointer.

* Initialize SlicePool with given capacity

* upd [email protected]

---------

Co-authored-by: Ronen Hilewicz <[email protected]>

---------

Co-authored-by: Ronen Hilewicz <[email protected]>
Co-authored-by: Ronen Hilewicz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants