Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

safe.Checks + jobpool #64

Merged
merged 2 commits into from
Dec 30, 2024
Merged

safe.Checks + jobpool #64

merged 2 commits into from
Dec 30, 2024

Conversation

ronenh
Copy link
Contributor

@ronenh ronenh commented Dec 20, 2024 •
edited
Loading

  1. Implement a safe wrapper for CheckRequest.
  2. Add a JobPool abstraction that executes a set of jobs on a pool of goroutines.

@coveralls
Copy link

coveralls commented Dec 20, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12435860958

Details

  • 0 of 67 (0.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-1.1%) to 65.491%
Changes Missing Coverage Covered Lines Changed/Added Lines %
safe/checks.go 0 29 0.0%
jobpool/jobpool.go 0 38 0.0%
Totals Coverage Status
Change from base Build 12278032314: -1.1%
Covered Lines: 2636
Relevant Lines: 4025
💛 - Coveralls

@ronenh ronenh requested a review from gertd December 20, 2024 17:21
@ronenh
Rename checks iterator to CheckRequests()
22058cc 
To avoid hiding the CheckRequests.Checks field.
@ronenh ronenh mentioned this pull request Dec 20, 2024
Merged
@ronenh ronenh merged commit 6b9e433 into main Dec 30, 2024
2 checks passed
@ronenh ronenh deleted the checks branch December 30, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gertd gertd gertd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ronenh @coveralls @gertd