Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add validation for Diff struct #8

Merged
merged 7 commits into from
Nov 3, 2023
Merged

Add validation for Diff struct #8

merged 7 commits into from
Nov 3, 2023

Conversation

oanatmaria
Copy link
Contributor

No description provided.

@oanatmaria oanatmaria requested a review from ronenh October 19, 2023 14:34
@github-actions
Copy link

github-actions bot commented Oct 19, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6730637940

  • 86 of 99 (86.87%) changed or added relevant lines in 4 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+2.2%) to 51.724%
Changes Missing Coverage Covered Lines Changed/Added Lines %
cache/cache.go 0 5 0.0%
model/diff/diff.go 41 49 83.67%
Files with Coverage Reduction New Missed Lines %
model/model.go 2 70.31%
Totals Coverage Status
Change from base Build 6698827008: 2.2%
Covered Lines: 690
Relevant Lines: 1334
💛 - Coveralls

ronenh
ronenh reviewed Oct 20, 2023
View reviewed changes
cache/cache.go Outdated Show resolved Hide resolved
model/diff/diff.go Outdated Show resolved Hide resolved
model/diff/diff.go Outdated Show resolved Hide resolved
@oanatmaria oanatmaria requested a review from ronenh October 26, 2023 13:13
ronenh
ronenh reviewed Oct 31, 2023
View reviewed changes
model/diff/diff.go Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
ronenh
ronenh previously approved these changes Oct 31, 2023
View reviewed changes
@oanatmaria oanatmaria merged commit 943935c into main Nov 3, 2023
2 checks passed
@oanatmaria oanatmaria deleted the add_diff_validate branch November 3, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronenh ronenh ronenh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oanatmaria @ronenh