Remove sync.Pool for relation-identifier buffers. (#117)

pkg/ds/relation.go

@@ -6,7 +6,6 @@ import (
 	"bytes"
 	"strings"
 
-	"github.com/aserto-dev/azm/mempool"
 	"github.com/aserto-dev/azm/safe"
 	dsc3 "github.com/aserto-dev/go-directory/aserto/directory/common/v3"
 	dsr3 "github.com/aserto-dev/go-directory/aserto/directory/reader/v3"
@@ -15,10 +14,6 @@ import (
 	"github.com/rs/zerolog/log"
 )
 
-const maxRelationSize = 832
-
-var bufPool = mempool.NewSlicePool[byte](maxRelationSize)
-
 // Relation identifier.
 type relation struct {
 	*safe.SafeRelation
@@ -60,10 +55,7 @@ func (i *relation) Key() []byte {
 }
 
 func (i *relation) ObjKey() []byte {
-	ptr := bufPool.Get()
-	defer bufPool.Put(ptr)
-
-	buf := bytes.NewBuffer(*ptr)
+	buf := newRelationBuffer()
 
 	buf.WriteString(i.GetObjectType())
 	buf.WriteByte(TypeIDSeparator)
@@ -86,10 +78,7 @@ func (i *relation) ObjKey() []byte {
 }
 
 func (i *relation) SubKey() []byte {
-	ptr := bufPool.Get()
-	defer bufPool.Put(ptr)
-
-	buf := bytes.NewBuffer(*ptr)
+	buf := newRelationBuffer()
 
 	buf.WriteString(i.GetSubjectType())
 	buf.WriteByte(TypeIDSeparator)
@@ -126,10 +115,7 @@ func (i *relation) PathAndFilter() ([]string, []byte, error) {
 // format: obj_type : obj_id # relation @ sub_type : sub_id (# sub_relation).
 // TODO: if subject relation exists add subject relation to filter clause.
 func (i *relation) ObjFilter() []byte {
-	ptr := bufPool.Get()
-	defer bufPool.Put(ptr)
-
-	buf := bytes.NewBuffer(*ptr)
+	buf := newRelationBuffer()
 
 	buf.WriteString(i.GetObjectType())
 	buf.WriteByte(TypeIDSeparator)
@@ -163,10 +149,7 @@ func (i *relation) ObjFilter() []byte {
 // format: sub_type : sub_id (# sub_relation) | obj_type : obj_id # relation.
 // TODO: if subject relation exists add subject relation to filter clause.
 func (i *relation) SubFilter() []byte {
-	ptr := bufPool.Get()
-	defer bufPool.Put(ptr)
-
-	buf := bytes.NewBuffer(*ptr)
+	buf := newRelationBuffer()
 
 	buf.WriteString(i.GetSubjectType())
 	buf.WriteByte(TypeIDSeparator)
@@ -363,3 +346,9 @@ func (i *relation) RelationValueFilter() (path bdb.Path, keyFilter []byte, value
 
 	return path, keyFilter, valueFilter
 }
+
+const maxRelationIdentifierSize = 384
+
+func newRelationBuffer() *bytes.Buffer {
+	return bytes.NewBuffer(make([]byte, 0, maxRelationIdentifierSize))
+}