checks-updates

[gertd]

• remove userset.go (dead code).
• add ScanX, moving value filter inline, saving the second iteration over the getRelations results array.
• move the UpdateMetadata* functions from the bdb (store) to ds namespace.
• replace bdb.ErrIsNotFound with generic status.Code(err) == codes.NotFound.
• switch message marshaling to use proto.Un|Marshal instead of protojson.Un|Marshal ~15% on-disk saving.
  • 108 -> 92 MB

[coveralls]

Pull Request Test Coverage Report for Build 12207398244

Details

• 45 of 251 (17.93%) changed or added relevant lines in 12 files are covered.
• 17 unchanged lines in 4 files lost coverage.
• Overall coverage decreased (-0.04%) to 27.794%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/bdb/migrate/mig/mig.go	0	1	0.0%
pkg/directory/v3/model.go	0	2	0.0%
pkg/directory/v3/writer.go	2	4	50.0%
pkg/bdb/generic.go	11	14	78.57%
pkg/datasync/manifest.go	0	3	0.0%
pkg/ds/check.go	0	4	0.0%
pkg/datasync/handlers.go	0	5	0.0%
pkg/directory/v3/importer.go	0	5	0.0%
pkg/datasync/directory.go	0	11	0.0%
pkg/bdb/scanner.go	1	51	1.96%

Files with Coverage Reduction	New Missed Lines	%
pkg/bdb/scanner.go	1	25.18%
pkg/bdb/generic.go	4	52.24%
pkg/bdb/migrate/mig/mig.go	6	32.98%
pkg/bdb/migrate/mig006/migrate.go	6	0.0%

Totals
Change from base Build 12018555558:	-0.04%
Covered Lines:	935
Relevant Lines:	3364

---

💛 - Coveralls