Assign slice back to out pointer after appends #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gertd
approved these changes
Dec 6, 2024
gertd
added a commit
that referenced
this pull request
Dec 11, 2024
* rm userset.go (deadcode) * add ScanX inline value filter * mv UpdateMetadata to ds * replace bdb.ErrIsNotFound with status.Code(err) == codes.NotFound * use proto.Un|Marshal instead of protojson.Un|Marshal * use azm@cache-inverted-model * use azm@cache-inverted-model * use azm@cache-inverted-model * refactor Scan, ScanWithFilter and KeyPrefixExist * rm go.mod replace * rm SessionID * move cursor up * Write relations to pre-allocated slices (#110) * update azm@cache-inverted-model * upd deps * go.sum * Assign slice back to out pointer after appends (#111) * Use azm@relpool * Azm with timestamppb.Timestamp pool * Use go-directory with vtproto * relpool changes + RelationId refactoring (#113) * convert keyFilter from string to []byte * convert azm to use RelationIdentifier * convert azm to use RelationIdentifier * upd go-directory@vtproto & azm@relpoot-rid * go mod tid * update deps * Use sync.Pool for relation filter buffers (#114) * azm with shared relations poo * sync.Pool for relation filter buffers * Remove profiling in reader.Check (#115) * Remove profiling in reader.Check * Use NewSlicePool from azm/mempool * upd [email protected] [email protected] --------- Co-authored-by: Ronen Hilewicz <[email protected]> Co-authored-by: Ronen Hilewicz <[email protected]> --------- Co-authored-by: Ronen Hilewicz <[email protected]> Co-authored-by: Ronen Hilewicz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ScanWithFilter appends to the array, which could return a new pointer, but it wasn't assigning it back to the
outpointer.