Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upd req validation and error handling #55

Merged
merged 1 commit into from
Nov 9, 2023
Merged

upd req validation and error handling #55

merged 1 commit into from
Nov 9, 2023

Conversation

gertd
Copy link
Member

@gertd gertd commented Nov 9, 2023

  1. Apply the updated proto-validation logic for Reader.GetRelation and Reader.GetRelations
  2. Update the returns error to be wrapped in derr.ErrProtoValidate with the Msg part containing the message from the proto validation

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 9, 2023

Pull Request Test Coverage Report for Build 6807634184

  • 0 of 18 (0.0%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 37.567%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/ds/relation.go 0 1 0.0%
pkg/directory/v3/importer.go 0 2 0.0%
pkg/directory/v3/model.go 0 2 0.0%
pkg/directory/v3/writer.go 0 4 0.0%
pkg/directory/v3/reader.go 0 9 0.0%
Totals Coverage Status
Change from base Build 6765705245: 0.0%
Covered Lines: 1266
Relevant Lines: 3370
💛 - Coveralls

@gertd gertd merged commit a0165d7 into main Nov 9, 2023
2 checks passed
@gertd gertd deleted the upd-validation branch November 9, 2023 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gertd