Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect cycles in check functions #57

Merged
merged 2 commits into from
Nov 13, 2023
Merged

Detect cycles in check functions #57

merged 2 commits into from
Nov 13, 2023

Conversation

ronenh
Copy link
Contributor

@ronenh ronenh commented Nov 13, 2023

Also use protobuf helper functions from go-directory/pkg/pb.

@ronenh ronenh requested a review from gertd November 13, 2023 23:20
@github-actions GitHub Actions
Copy link

Pull Request Test Coverage Report for Build 6856956169

  • 0 of 23 (0.0%) changed or added relevant lines in 3 files are covered.
  • 3 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.3%) to 37.091%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/ds/check_relation.go 0 5 0.0%
pkg/ds/check_permission.go 0 8 0.0%
pkg/ds/check.go 0 10 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/ds/check.go 1 0.0%
pkg/ds/check_permission.go 1 0.0%
pkg/ds/check_relation.go 1 0.0%
Totals Coverage Status
Change from base Build 6845999483: -0.3%
Covered Lines: 1247
Relevant Lines: 3362
💛 - Coveralls

@gertd gertd merged commit b6c3305 into main Nov 13, 2023
2 checks passed
@gertd gertd deleted the detect-cycles branch November 13, 2023 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gertd gertd gertd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ronenh @gertd