Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix If-None-Match handling in GetManifest #62

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Fix If-None-Match handling in GetManifest #62

merged 1 commit into from
Nov 20, 2023

Conversation

ronenh
Copy link
Contributor

@ronenh ronenh commented Nov 20, 2023

It was comparing the value of the header to an ETag that's always empty.

@ronenh
Fix If-None-Match handling in GetManifest
8d3a812 
It was comparing the value of the header to an ETag that's always
empty.
@ronenh ronenh requested a review from gertd November 20, 2023 15:41
@github-actions GitHub Actions
Copy link

Pull Request Test Coverage Report for Build 6932405102

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 28.435%
Totals Coverage Status
Change from base Build 6910066963: 0.0%
Covered Lines: 983
Relevant Lines: 3457
💛 - Coveralls

@gertd gertd merged commit af598b3 into main Nov 20, 2023
2 checks passed
@gertd gertd deleted the if-none-match branch November 20, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gertd gertd gertd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ronenh @gertd