Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edge-sync updates #88

Merged
merged 4 commits into from
Apr 11, 2024
Merged

edge-sync updates #88

merged 4 commits into from
Apr 11, 2024

Conversation

gertd
Copy link
Member

@gertd gertd commented Apr 8, 2024

  • consolidate the usage of the validator to a single pre-allocated shared instance on the directory instance
  • update schemaVersion.schemaVersion from 0.0.4 to 0.0.6
  • make directory a singleton

Copy link

github-actions bot commented Apr 8, 2024

Pull Request Test Coverage Report for Build 8639354749

Details

  • 110 of 175 (62.86%) changed or added relevant lines in 8 files are covered.
  • 7 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.7%) to 31.713%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/directory/v3/writer.go 13 15 86.67%
pkg/directory/v3/exporter.go 4 7 57.14%
pkg/datasync/datasync.go 0 4 0.0%
pkg/bdb/metadata.go 21 27 77.78%
pkg/directory/v3/reader.go 10 16 62.5%
pkg/directory/directory.go 43 50 86.0%
pkg/directory/v3/importer.go 4 16 25.0%
pkg/bdb/generic.go 15 40 37.5%
Files with Coverage Reduction New Missed Lines %
pkg/bdb/metadata.go 1 80.43%
pkg/bdb/migrate/mig004/migrate.go 6 0.0%
Totals Coverage Status
Change from base Build 8510317706: 0.7%
Covered Lines: 1181
Relevant Lines: 3724

💛 - Coveralls

@gertd gertd merged commit 08848ad into main Apr 11, 2024
2 checks passed
@gertd gertd deleted the fix/edge-sync branch April 11, 2024 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant