Logging helper to wire logrus to zerolog #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gertd
approved these changes
Aug 22, 2024
ronenh
added a commit
to opcr-io/policy
that referenced
this pull request
Aug 22, 2024
The dependency on logrus was removed from aserto-dev/logger in aserto-dev/logger#8. Support for wiring logrus to zerolog has moved to aserto-dev/runtime in aserto-dev/runtime#57. This commit uses runtime/logger to explicitly add a logrus hook that sends logs to zerolog. Signed-off-by: Ronen Hilewicz [email protected]
ronenh
added a commit
to opcr-io/policy
that referenced
this pull request
Aug 22, 2024
The dependency on logrus was removed from aserto-dev/logger in aserto-dev/logger#8. Support for wiring logrus to zerolog has moved to aserto-dev/runtime in aserto-dev/runtime#57. This commit uses runtime/logger to explicitly add a logrus hook that sends logs to zerolog. Signed-off-by: Ronen Hilewicz <[email protected]>
gertd
pushed a commit
to opcr-io/policy
that referenced
this pull request
Aug 23, 2024
The dependency on logrus was removed from aserto-dev/logger in aserto-dev/logger#8. Support for wiring logrus to zerolog has moved to aserto-dev/runtime in aserto-dev/runtime#57. This commit uses runtime/logger to explicitly add a logrus hook that sends logs to zerolog. Signed-off-by: Ronen Hilewicz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OPA uses logrus, which we want to reroute to a
zerolog.Logger.This commit adds a helper that used to be in aserto-dev/logger but is only needed by binaries that import OPA.