-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement NoTLS (--plaintext) support #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 11866052369Details
💛 - Coveralls |
ensure test-snapshot produces a valid semver container tag Revert "ensure test-snapshot produces a valid semver container tag" This reverts commit cdcb176. use valid semver for test image use unique db file name for templates-no-tls cleanup tests (testifylint) cleanup linter issues rm go.opencensus.io (deprecated) dependencies update test db master adopt [email protected] TLSConfig & [email protected]
ronenh
reviewed
Nov 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good but if we move the service builder into internal, I think it might be possible to remove the service-host reference entirely
ronenh
previously approved these changes
Nov 15, 2024
ronenh
previously approved these changes
Nov 15, 2024
aserto-bot
approved these changes
Nov 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements:
--plaintext
For the service part, when:
certs
block entries contain empty string(s), like:or
the
certs
block contains no entries like:or
when no
certs
block is presentthe gRPC service instance will start without the associated TLS credentials.
The
topaz
CLI add the--plaintext
or-P
parameter to indicate that the gRPC connection will use plain-text HTTP/2 when connecting to server (no TLS).When using
grpcurl
orgrpcui
use the-plaintext
command line flag.This PR also changes the default security mode of the
health
andmetrics
services to by default run with NoTLS.