Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds store_inputs? true/false option #29

Closed

Commits on Oct 11, 2023

  1. feat: adds store_inputs? true/false option

    closes: ash-project#20
    
    - introduces `store_inputs?` to the DSL
    - `store_inputs?` if not included defaults to false
    - when switched on it ensure an attribute is created to capture the exact
      inputs of each new version, when the resource we are paper-trailing changes.
    chrishop committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    ae8f918 View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2023

  1. feat: normalise orignal inputs as maps

    When we use `store_inputs? true` we store the original inputs of the change as
    map. Within this map all structs representing Ash Resources are converted into
    a map using `Ash.Type.dump_to_embedded/3`.
    
    We use the function `normalise_inputs/1` to do this which will deeply recurse
    within maps and lists to ensure all Ash Resource have been converted into their
    embedded counterpart.
    chrishop committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    b16d054 View commit details
    Browse the repository at this point in the history
  2. chore: mark inputs as sensitive

    This is a temporary measure, the eventual goal is to inspect each value in the
    inputs, if that value is sensitive then we'll redact it from the inputs stored
    in the version
    chrishop committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    5ad9e32 View commit details
    Browse the repository at this point in the history
  3. comment that user input will be stored as plain text, including passw…

    …ords
    
    Co-authored-by: Robert Graff <[email protected]>
    chrishop and rgraff authored Oct 12, 2023
    Configuration menu
    Copy the full SHA
    c83d3fc View commit details
    Browse the repository at this point in the history