Overhaul Accelerator repository #13

Kenzzer · 2024-01-28T00:47:21Z

Added protobuf and breakpad as submodule

It's no secret that google's tools to fetch their repositories are absolutely horrendous to use, not counting that they're also outdated in regard to python's version. Fortunately for us, google had the decency to make public mirrors of their repository over to github, let's take advantage of that and link to these repositories.

Edit : It seems cloning protobuf is completly unnecessary to compile breakpad

Updated breakpad.sh to compile breakpad for both 32bits and 64bits

Just like the title implies, I've updated the script to compile breakpad for each architecture. I've also revised some of the patches, so they work with the breakpad submodule I decided to set the hash to. One of these patches also became unnecessary, as its change became official.

Edit : This is now part of the ambuild scripts

Overhauled AMBuild scripts

Those were some very old, and confusing to look at build scripts. I brought them up to modern ambuild syntax.

Updated the extension code

I modified a few lines of the extension, so that it may compile with the newest breakpad code. As well as the definition of GetSpew function, which was invalid for 64 bits.

Update Gamedata

TF2 x64 bits is out, gamedata needs a little update

Added a CI

CI(s) are cool ! It compiles the extension for latest ubuntu and windows, and also on an older version of both OSes.

adriansmares · 2024-04-22T10:10:31Z

I've tried to use the Linux artifacts on L4D2 under Debian bookworm (same base as Ubuntu 22.04). I managed to make it work, but I have some comments:

zlib is now a dependency - this is different from the latest HEAD, and probably should be documented somewhere. I only had to install zlib1g:i386 and this stopped being an issue.
The libstdc++ which is bundled with L4D2 seems to be quite old and results in this issue:

[SM] Unable to load extension "accelerator.ext": bin/libstdc++.so.6: version `GLIBCXX_3.4.21' not found (required by /home/steam/srcds/left4dead2/addons/sourcemod/extensions/accelerator.ext.so)

Since the libraries in the server bin folder have priority, whatever I installed on the host did not really matter. I fixed this by statically linking libgcc and libstdc++. This is a blatant copy paste from SourceMod, so maybe there are side effects or it could simply be shorter (specifically I don't think -lm is needed).

Kenzzer · 2024-04-25T14:32:28Z

zlib is now a dependency - this is different from the latest HEAD, and probably should be documented somewhere. I only had to install zlib1g:i386 and this stopped being an issue.

ZLib will allow breakpad greater symbol coverage, which in turn should benefit the generated minidumps. Extensions dependencies are usually not documented (wrongly so). I will let @asherkin decide whether or not it should be listed somewhere, or if we should swap to static linkage or take it out entirely.

I fixed this by statically linking libgcc and libstdc++.

Thank you valve. I will address this at the same time as the zlib issue in order to avoid two more commits. As the excessive amount was the reason this branch was asked to be rebased and squashed by Asherkin.

adriansmares · 2024-04-26T15:55:37Z

On TF2 x64 the SourcePawn JIT binary is unavailable (there is no x64 JIT):

[CRASH] WARNING: Failed to load SourcePawn library /home/steam/srcds/tf/addons/sourcemod/bin/x64/sourcepawn.jit.x86.so: /home/steam/srcds/tf/addons/sourcemod/bin/x64/sourcepawn.jit.x86.so: cannot open shared object file: No such file or directory

It seems that the VM binary however exposes the same interface, and accelerator seems to load well if that binary is used.

asherkin · 2024-04-27T14:08:27Z

ZLib will allow breakpad greater symbol coverage, which in turn should benefit the generated minidumps.

This is for compressed DWARF symbols, right?

Statically linking all 3 feels correct.

sapphonie · 2024-04-27T19:28:22Z

@Kenzzer lmk when i should review this 👀

add protobuf change repo url try to restore github python syntax highlighter move breakpad into third_party, update packagescript

remove unnecessary files Move the git patching into ambuild move lss to a patch Add windows compilation support remove breakpad.bat move postlink libs

* make cwd_cmd spew stdout and stderr * add proper docker build support * Overhaul ci (#6) * Setup CI * fix checkout * fix yaml syntax * no fail fast * setup CI cache * Fix pip install * remove pip git * update actions, ditch node 16 * small syntax cleanups * more CI changes * github doc lied --------- Co-authored-by: Kenzzer <[email protected]> * final push for perfect dockerbuilds in every scenario that i have been able to find * rename cicd->dockerbuild --------- Co-authored-by: Kenzzer <[email protected]>

update names of dockerbuild folder in sh files

Kenzzer · 2024-10-04T10:55:45Z

Sorry for the long delay @adriansmares other x64 fixes took priority (namely sourcehook & dhooks). This should be enough for accelerator to work again on l4d2.

@asherkin Zlib had to be added as a submodule because statically linking against the one provided by linux apt packages will result in compilation error.
/usr/bin/ld: /lib/x86_64-linux-gnu/libz.a(zutil.o): relocation R_X86_64_PC32 against symbol 'z_errmsg' can not be used when making a shared object; recompile with -fPIC

As such we have to recompile zlib ourselves with -fPIC

asherkin

Really nice work on this - left a smattering of comments.

asherkin · 2024-10-06T13:07:49Z

dockerbuild/accelerator_docker_build.sh

This docker stuff isn't used by the CI from what I can see, right? It's just a helper for manual builds?

Made by sappho, and she really wanted me to keep this in since this could help people building the extension manually. Though I'll leave further comments to her.

asherkin · 2024-10-06T13:08:15Z

dockerbuild/accelerator_docker_build.sh

+# we do this so that we can be agnostic about where we're invoked from
+# meaning you can exec this script anywhere and it should work the same
+thisiswhereiam=${BASH_SOURCE[0]}
+# this should be /whatever/directory/structure/Open-Fortress-Source


It should be?

Ditto. @sapphonie

Sorry, copied this build script from myself somewhere else 👀 , the directory structure shouldn't matter

You can yeet the entire dockerbuild/ folder if you want, it's not really needed with proper GH actions

Noted! I'll rebase this one last time.

extension/smsdk_config.h

patches/0002-Write-FUNC-records-instead-of-PUBLIC-for-ELF-symbols.patch

extension/extension.cpp

patches/0003-Avoid-using-_ZNSsC1ERKSsjRKSaIcE-GLIBCXX-symbol-due-.patch

third_party/Patch

sapphonie · 2024-10-11T01:57:21Z

Unknown if this fixes #20 because actions aren't set up, can those be enabled on PR please 👍

sapphonie · 2024-10-11T14:35:09Z

#20 fixed by #22, actions are now being built on overhaul branch which i merged to this repo ( #21 )

sapphonie mentioned this pull request Jan 28, 2024

dockerized / ambuildized builds on linux + pulled in community forks for newer breakpad & [TODO] cicd compile #11

Closed

Kenzzer force-pushed the overhaul branch 3 times, most recently from 1216092 to afba416 Compare January 30, 2024 15:24

Kenzzer marked this pull request as ready for review January 31, 2024 10:48

Kenzzer force-pushed the overhaul branch from 58e3ae7 to 2c74bcc Compare April 19, 2024 22:43

sapphonie self-assigned this Apr 27, 2024

Kenzzer mentioned this pull request May 12, 2024

Replacing CDetour alliedmodders/sourcemod#2153

Closed

sapphonie mentioned this pull request Jul 1, 2024

x64 support needed for Military Conflict Vietnam and upcoming x64 TF2 update #12

Open

Kenzzer force-pushed the overhaul branch from fcce271 to 951b655 Compare October 4, 2024 10:40

Kenzzer and others added 9 commits October 4, 2024 12:51

overhaul the repository

f40e384

add protobuf change repo url try to restore github python syntax highlighter move breakpad into third_party, update packagescript

AMBuildifying

c830608

remove unnecessary files Move the git patching into ambuild move lss to a patch Add windows compilation support remove breakpad.bat move postlink libs

Overhaul CI (#4)

844e88a

Add readme, remode duplicate -fPIC

d1f2670

update names of dockerbuild folder in sh files

cleanup dockerfile (#7)

8af3759

Update 0002-Write-FUNC-records-instead-of-PUBLIC-for-ELF-symbols.patch

3a81365

Statically link libz, libgcc & libstdc++

12b923b

fix submodule path

537fde5

Kenzzer force-pushed the overhaul branch from 097cfd2 to 537fde5 Compare October 4, 2024 10:52

sapphonie assigned sapphonie and unassigned sapphonie Oct 5, 2024

asherkin reviewed Oct 6, 2024

View reviewed changes

Review change + comment patch

dc8688a

Kenzzer force-pushed the overhaul branch from 86cb425 to dc8688a Compare October 6, 2024 14:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Overhaul Accelerator repository #13

Overhaul Accelerator repository #13

Kenzzer commented Jan 28, 2024 •

edited

Loading

adriansmares commented Apr 22, 2024 •

edited

Loading

Kenzzer commented Apr 25, 2024

adriansmares commented Apr 26, 2024

asherkin commented Apr 27, 2024

sapphonie commented Apr 27, 2024

Kenzzer commented Oct 4, 2024

asherkin left a comment

asherkin Oct 6, 2024

Kenzzer Oct 6, 2024

asherkin Oct 6, 2024

Kenzzer Oct 6, 2024

sapphonie Oct 6, 2024

Kenzzer Oct 7, 2024

sapphonie commented Oct 11, 2024

sapphonie commented Oct 11, 2024 •

edited

Loading

Overhaul Accelerator repository #13

Are you sure you want to change the base?

Overhaul Accelerator repository #13

Conversation

Kenzzer commented Jan 28, 2024 • edited Loading

Added protobuf and breakpad as submodule

Updated breakpad.sh to compile breakpad for both 32bits and 64bits

Overhauled AMBuild scripts

Updated the extension code

Update Gamedata

Added a CI

adriansmares commented Apr 22, 2024 • edited Loading

Kenzzer commented Apr 25, 2024

adriansmares commented Apr 26, 2024

asherkin commented Apr 27, 2024

sapphonie commented Apr 27, 2024

Kenzzer commented Oct 4, 2024

asherkin left a comment

Choose a reason for hiding this comment

asherkin Oct 6, 2024

Choose a reason for hiding this comment

Kenzzer Oct 6, 2024

Choose a reason for hiding this comment

asherkin Oct 6, 2024

Choose a reason for hiding this comment

Kenzzer Oct 6, 2024

Choose a reason for hiding this comment

sapphonie Oct 6, 2024

Choose a reason for hiding this comment

Kenzzer Oct 7, 2024

Choose a reason for hiding this comment

sapphonie commented Oct 11, 2024

sapphonie commented Oct 11, 2024 • edited Loading

Kenzzer commented Jan 28, 2024 •

edited

Loading

adriansmares commented Apr 22, 2024 •

edited

Loading

sapphonie commented Oct 11, 2024 •

edited

Loading