Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 404 not found page redesigned #303

Merged
merged 2 commits into from
Jun 21, 2024

Conversation

RamakrushnaBiswal
Copy link
Contributor

Related Issue

#302 solved

Description

404 not found page added

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Screenshots / videos (if applicable)

image

Checklist:

  • I have performed a self-review of my code
  • I have read and followed the Contribution Guidelines.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Additional context:

[Include any additional information or context that might be helpful for reviewers.]

Copy link

vercel bot commented Jun 19, 2024

@RamakrushnaBiswal is attempting to deploy a commit to the lucif3rin's projects Team on Vercel.

A member of the Team first needs to authorize it.

@ashutosh-rath02
Copy link
Owner

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations🎉 on creating your first pull request in Git-re.' first pull request

@RamakrushnaBiswal
Copy link
Contributor Author

hi @ashutosh-rath02 please review the PR

Copy link

vercel bot commented Jun 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
git-re ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 19, 2024 3:25pm

@ashutosh-rath02
Copy link
Owner

ashutosh-rath02 commented Jun 19, 2024

Hey @RamakrushnaBiswal is this design copied from somewhere? Also give some padding between the items

@RamakrushnaBiswal
Copy link
Contributor Author

i just get the svg from online if you want i can change @ashutosh-rath02

@RamakrushnaBiswal
Copy link
Contributor Author

image

@RamakrushnaBiswal
Copy link
Contributor Author

hi @ashutosh-rath02 review the PR

@ashutosh-rath02 ashutosh-rath02 merged commit 950b259 into ashutosh-rath02:main Jun 21, 2024
7 checks passed
@RamakrushnaBiswal RamakrushnaBiswal deleted the ram-dev branch June 21, 2024 05:47
@RamakrushnaBiswal
Copy link
Contributor Author

@ashutosh-rath02 sir add some labels and assign 🙂

Copy link
Owner

@ashutosh-rath02 ashutosh-rath02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants