Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solves User is rate-limited by GitHub (issue324) #321

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

Swastik19Nit
Copy link
Contributor

@Swastik19Nit Swastik19Nit commented Jun 26, 2024

Related Issue

Encountering the "Data is NULL. User is rate-limited by GitHub" error for some usernames.

Description

#324

Type of PR

  • [ X] Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Screenshots / videos (if applicable)

image
image

Checklist:

  • [X ] I have performed a self-review of my code
  • [X ] I have read and followed the Contribution Guidelines.
  • [X ] I have tested the changes thoroughly before submitting this pull request.
  • [ X] I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • [ X] I have commented my code, particularly in hard-to-understand areas.

Additional context:

The current code checks if userData.name is null or empty to determine if the user is rate-limited. However, this might not be the most reliable method, as some users might genuinely have no name set on their GitHub profile. So it should be changed to userData.username.

Copy link

vercel bot commented Jun 26, 2024

@Swastik19Nit is attempting to deploy a commit to the lucif3rin's projects Team on Vercel.

A member of the Team first needs to authorize it.

@ashutosh-rath02
Copy link
Owner

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations🎉 on creating your first pull request in Git-re.' first pull request

@Swastik19Nit
Copy link
Contributor Author

@ashutosh-rath02

@Swastik19Nit
Copy link
Contributor Author

Swastik19Nit commented Jun 26, 2024

@ashutosh-rath02 i dont know whether my pull request is actually related to this issue or not but there is one problem we are encountering "Data is NULL. User is rate-limited by GitHub" error for some usernames which i have debugged . So should i raise an issue for this first?

@ashutosh-rath02
Copy link
Owner

@dhairyathedev

@dhairyathedev
Copy link
Contributor

Hey @Swastik19Nit,

#319 is not related to this PR.

But, nice catch! You can merge this PR @ashutosh-rath02

@ashutosh-rath02
Copy link
Owner

@Swastik19Nit raise an issue so that your PR gets counted under GSSoC

Copy link

vercel bot commented Jun 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
git-re ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 26, 2024 11:01am

@Swastik19Nit Swastik19Nit changed the title solves User is rate-limited by GitHub (issue319) solves User is rate-limited by GitHub (issue324) Jun 26, 2024
@ashutosh-rath02 ashutosh-rath02 merged commit b53d513 into ashutosh-rath02:main Jun 26, 2024
11 checks passed
Copy link
Owner

@ashutosh-rath02 ashutosh-rath02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants