-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
solves User is rate-limited by GitHub (issue324) #321
Conversation
@Swastik19Nit is attempting to deploy a commit to the lucif3rin's projects Team on Vercel. A member of the Team first needs to authorize it. |
Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congratulations🎉 on creating your first pull request in Git-re.' first pull request
@ashutosh-rath02 i dont know whether my pull request is actually related to this issue or not but there is one problem we are encountering "Data is NULL. User is rate-limited by GitHub" error for some usernames which i have debugged . So should i raise an issue for this first? |
Hey @Swastik19Nit, #319 is not related to this PR. But, nice catch! You can merge this PR @ashutosh-rath02 |
@Swastik19Nit raise an issue so that your PR gets counted under GSSoC |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Related Issue
Encountering the "Data is NULL. User is rate-limited by GitHub" error for some usernames.
Description
#324
Type of PR
Screenshots / videos (if applicable)
Checklist:
Additional context:
The current code checks if userData.name is null or empty to determine if the user is rate-limited. However, this might not be the most reliable method, as some users might genuinely have no name set on their GitHub profile. So it should be changed to userData.username.