Fix: Testimonial link on Leaderboard page does not navigate to the Testimonial page #354

Shahbaz898414 · 2024-07-02T14:50:17Z

Description

This pull request addresses the issue where the link to the Testimonial page on the Leaderboard page does not navigate to the Testimonial page. This fix ensures that users can access the Testimonial page by clicking the link on the Leaderboard page.

Changes Made

Corrected the href attribute for the Testimonial link on the Leaderboard page to ensure proper navigation.

Issue Reference

Fixes [#287 ]

Steps to Test

Go to the Leaderboard page.
Click on the Testimonial link.
Verify that the page navigates to the Testimonial page.

Expected Behavior

After clicking the link to the Testimonial page on the Leaderboard page, the user should be redirected to the Testimonial page.

Screenshots

vercel · 2024-07-02T14:50:22Z

@Shahbaz898414 is attempting to deploy a commit to the lucif3rin's projects Team on Vercel.

A member of the Team first needs to authorize it.

ashutosh-rath02 · 2024-07-02T14:50:29Z

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

github-actions

Congratulations🎉 on creating your first pull request in Git-re.' first pull request

ashutosh-rath02 · 2024-07-02T15:14:58Z

@dhairyathedev

dhairyathedev · 2024-07-02T17:32:38Z

components/navbar.tsx

+        {currentPath === "/leaderboard" ? (
+          <Link
+            href={"/#userTestimonials"}
+            className="text-navbarSecondary hover:text-primary font-semibold transition md:block hidden dark:text-white"
+            style={{ scrollBehavior: "smooth" }}
+          >
+            Testimonial
+          </Link>
+        ) : (
+          <a
+            href="#userTestimonials"
+            className="text-navbarSecondary hover:text-primary font-semibold transition md:block hidden dark:text-white"
+            style={{ scrollBehavior: "smooth" }}
+          >
+            Testimonial
+          </a>
+        )}


Remove this

If i remove this will not work,

can you plz provide me more information ?

@dhairyathedev

The simple solution is to just change the href and don't need this pass checks.

bro can you connect with me on Linkedin

dhairyathedev · 2024-07-02T17:34:53Z

components/navbar.tsx

-        <a
-          href="#userTestimonials"
-          className="text-navbarSecondary hover:text-primary font-semibold transition md:block hidden dark:text-white"
-          style={{ scrollBehavior: "smooth" }}
-        >
-          Testimonial
-        </a>


One line fix: revert this component and update the href to href="/#userTestimonials". Also, change the <a> tag to use <Link> from next/link.

Implement this @Shahbaz898414

dhairyathedev · 2024-07-02T17:35:25Z

components/navbar.tsx

@@ -1,18 +1,30 @@
-import React from "react";
+"use client";  // Mark this component as a Client Component


remove this

dhairyathedev · 2024-07-02T17:35:50Z

components/navbar.tsx

+import { createClientComponentClient } from "@supabase/auth-helpers-nextjs";
+import { usePathname } from "next/navigation";  // Import the usePathname hook


Remove this

import { createClientComponentClient } from "@supabase/auth-helpers-nextjs";

only this one or both

dhairyathedev · 2024-07-02T17:35:54Z

components/navbar.tsx

 import { ModeToggle } from "./shared/ToggleBg";
 import { GitHubLogoIcon } from "@radix-ui/react-icons";
 import { IoMdGitNetwork } from "react-icons/io";
 import Link from "next/link";
 import { Button } from "./ui/button";
 import AuthButton from "./AuthButton";
 import Hamburger from "./Hamburger";
-import { supabaseServer } from "@/utils/supabase/server";


dhairyathedev · 2024-07-02T17:36:20Z

components/navbar.tsx

-export default async function Navbar() {
+export default function Navbar() {


Revert to original asynchronous function

dhairyathedev · 2024-07-02T17:36:35Z

components/navbar.tsx

-        <AuthButton user={data.user} />
+        <AuthButton user={user} />


Revert to original

dhairyathedev · 2024-07-02T17:36:48Z

middleware.ts

@@ -22,3 +22,4 @@ export const config = {
    "/((?!_next/static|_next/image|favicon.ico|.*\\.(?:svg|png|jpg|jpeg|gif|webp)$).*)",
  ],
 };
+


Remove extra whitespace

Resolve this please if not

dhairyathedev · 2024-07-02T17:37:11Z

.env.example

Revert the file delete.

vercel · 2024-07-02T18:42:08Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
git-re	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 11, 2024 2:40pm

dhairyathedev · 2024-07-03T11:25:23Z

@Shahbaz898414 Revert the file navbar.tsx to original state implement this solution: #354 (comment)

Shahbaz898414 · 2024-07-07T21:06:58Z

@Shahbaz898414 Revert the file navbar.tsx to original state implement this solution: #354 (comment)

@dhairyathedev Done bro plz check

ashutosh-rath02 · 2024-07-10T14:15:24Z

.env.example

Undo deletion of this file please

ashutosh-rath02 · 2024-07-10T14:15:38Z

middleware.ts

@@ -22,3 +22,4 @@ export const config = {
    "/((?!_next/static|_next/image|favicon.ico|.*\\.(?:svg|png|jpg|jpeg|gif|webp)$).*)",
  ],
 };
+


Resolve this please if not

Shahbaz898414 · 2024-07-11T05:53:22Z

@ashutosh-rath02
done bro

ashutosh-rath02

LGTM

Shahbaz898414 added 2 commits June 30, 2024 02:41

1

b53ca30

Resolved_Testimonial on Leaderboard page

395f460

github-actions bot reviewed Jul 2, 2024

View reviewed changes

dhairyathedev suggested changes Jul 2, 2024

View reviewed changes

vercel bot had a problem deploying to Preview July 2, 2024 18:43 Failure

Shahbaz898414 added 3 commits July 4, 2024 16:57

Merge branch 'ashutosh-rath02:main' into Resolved_Testimonial

d0ff7b0

Merge branch 'main' into Resolved_Testimonial

e08ae4c

Fix Testimonial link behavior on Leaderboard and Compare pages

bf53c73

ashutosh-rath02 requested changes Jul 10, 2024

View reviewed changes

Shahbaz898414 added 2 commits July 10, 2024 21:10

Update middleware.ts

09d5611

Create .env.example

dea7ac9

vercel bot deployed to Preview July 11, 2024 14:34 View deployment

Update .env.example

d8e93db

ashutosh-rath02 added GSSoC'24 level1 gssoc labels Jul 11, 2024

vercel bot deployed to Preview July 11, 2024 14:40 View deployment

ashutosh-rath02 approved these changes Jul 11, 2024

View reviewed changes

ashutosh-rath02 merged commit 36d19a4 into ashutosh-rath02:main Jul 11, 2024
10 checks passed

Shahbaz898414 deleted the Resolved_Testimonial branch July 11, 2024 16:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: Testimonial link on Leaderboard page does not navigate to the Testimonial page #354

Fix: Testimonial link on Leaderboard page does not navigate to the Testimonial page #354

Shahbaz898414 commented Jul 2, 2024

vercel bot commented Jul 2, 2024

ashutosh-rath02 commented Jul 2, 2024

github-actions bot left a comment

ashutosh-rath02 commented Jul 2, 2024

dhairyathedev Jul 2, 2024

Shahbaz898414 Jul 2, 2024

Shahbaz898414 Jul 3, 2024

dhairyathedev Jul 3, 2024

Shahbaz898414 Jul 3, 2024

dhairyathedev Jul 2, 2024

dhairyathedev Jul 3, 2024

Shahbaz898414 Jul 5, 2024

dhairyathedev Jul 2, 2024

dhairyathedev Jul 2, 2024

Shahbaz898414 Jul 2, 2024

dhairyathedev Jul 3, 2024

dhairyathedev Jul 2, 2024

dhairyathedev Jul 2, 2024

dhairyathedev Jul 2, 2024

dhairyathedev Jul 2, 2024

ashutosh-rath02 Jul 10, 2024

dhairyathedev Jul 2, 2024

vercel bot commented Jul 2, 2024 •

edited

Loading

dhairyathedev commented Jul 3, 2024

Shahbaz898414 commented Jul 7, 2024

ashutosh-rath02 Jul 10, 2024

ashutosh-rath02 Jul 10, 2024

Shahbaz898414 commented Jul 11, 2024

ashutosh-rath02 left a comment

		@@ -1,18 +1,30 @@
		import React from "react";
		"use client"; // Mark this component as a Client Component

		import { createClientComponentClient } from "@supabase/auth-helpers-nextjs";
		import { usePathname } from "next/navigation"; // Import the usePathname hook

		export default async function Navbar() {
		export default function Navbar() {

Fix: Testimonial link on Leaderboard page does not navigate to the Testimonial page #354

Fix: Testimonial link on Leaderboard page does not navigate to the Testimonial page #354

Conversation

Shahbaz898414 commented Jul 2, 2024

Description

Changes Made

Issue Reference

Steps to Test

Expected Behavior

Screenshots

vercel bot commented Jul 2, 2024

ashutosh-rath02 commented Jul 2, 2024

github-actions bot left a comment

Choose a reason for hiding this comment

ashutosh-rath02 commented Jul 2, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vercel bot commented Jul 2, 2024 • edited Loading

dhairyathedev commented Jul 3, 2024

Shahbaz898414 commented Jul 7, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Shahbaz898414 commented Jul 11, 2024

ashutosh-rath02 left a comment

Choose a reason for hiding this comment

vercel bot commented Jul 2, 2024 •

edited

Loading