Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ECS Service module in use to v3.2.0 PLAT-3853 #4

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

anuj-modi
Copy link

@anuj-modi anuj-modi commented Aug 29, 2019

I have made the changes in env-development and env-staging and looked at plan-dev and plan-staging in circleci. The results seemed correct but I don't really know how to verify further than this.

Additionally, I didn't see a healthcheck.tf in env-prod so I am not sure how to make the change for that.

  • Make change on env-development
  • Verify that the plan-dev CircleCI job produces expected results
  • Make change on env-staging
  • Verify that the plan-staging CircleCI job produces expected results
  • Do a dev deploy and verify results
  • Do a staging deploy and verify results

@anuj-modi anuj-modi requested a review from a team as a code owner August 29, 2019 15:50
@masteinhauser
Copy link

The only concern I have in the terraform plan output for env-staging is the following change:

~ pingdom_check.app_http
      sendnotificationwhendown:                        "2" => "0"

What does that mean and what effects might it have?

Copy link

@masteinhauser masteinhauser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awaiting feedback on my overall comment, and then approved once impact is understood.

@tfhartmann
Copy link
Contributor

If i recall, thats a change in the behavior of when notifications are sent.

sendnotificationwhendown - The number of consecutive failed checks required to trigger an alert. Values of 0 are ignored.

Heres a link to the README of the provider which may be helpful!

It looks like the "2" => "0" will change the pingdom behavior to cause failed checks to never send an alert.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants