Fix overlap margin calculation. #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current code is only called when a new compressed byte is read, not after the corresponding decompressed bytes are written. This means that the contents produced by the last byte of input are not taken into account, which can make a huge difference for instance on files with long sequences of zeros at the end.
rasky
added a commit
to rasky/libdragon
that referenced
this pull request
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code is only called when a new compressed byte is read, not after the corresponding decompressed bytes are written. This means that the contents produced by the last byte of input are not taken into account, which can make a huge difference for instance on files with long sequences of zeros at the end.