Skip to content

Commit

Permalink
fix: don't mutate the frozen values in lifecycle_hooks dict (#728)
Browse files Browse the repository at this point in the history
  • Loading branch information
mattem committed Dec 19, 2022
1 parent a60c9ab commit 5dfce6d
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions npm/npm_import.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -361,6 +361,7 @@ WARNING: `package_json` attribute in `npm_translate_lock(name = "{name}")` is de
fail("expected update_pnpm_lock to be True when preupdate are specified")

# lifecycle_hooks_exclude is a convenience attribute to set `<value>: []` in `lifecycle_hooks`
lifecycle_hooks = dict(lifecycle_hooks)
for p in lifecycle_hooks_exclude:
if p in lifecycle_hooks:
fail("expected '{}' to be in only one of lifecycle_hooks or lifecycle_hooks_exclude".format(p))
Expand Down

0 comments on commit 5dfce6d

Please sign in to comment.