Skip to content

Commit

Permalink
chore: bump to Bazel 6.0.0rc3 (#671)
Browse files Browse the repository at this point in the history
  • Loading branch information
gregmagolan committed Nov 30, 2022
1 parent 7004108 commit 8fef916
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 7 deletions.
5 changes: 1 addition & 4 deletions .bazelversion
Original file line number Diff line number Diff line change
@@ -1,7 +1,4 @@
0d2b4d67eefa2e3cd3f8f2374fc8a2a9c766d268
# NB: commit hash here is temporary until Bazel 6.0.0rc3 or 6.0.0 final are out (which ever is next).
# using last_green fails sometimes if the commit hash it resolves to doesn't yet have an bazel
# artifact available for download
6.0.0rc3
# The first line of this file is used by Bazelisk and Bazel to be sure
# the right version of Bazel is used to build and test this repo.
# This also defines which version is used on CI.
Expand Down
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@ Google does not fund development of rules_js. If your company benefits, please c

Known issues:

- Remote Execution (RBE) requires the latest version of Bazel, 6.0. Run `echo 6.0.0rc2 > .bazelversion` or set environment `USE_BAZEL_VERSION=6.0.0rc2`.
- With Bazel 6.0.0rc2 and `--remote_download_outputs` set to either `toplevel` or `minimal` there is an [issue](https://github.com/bazelbuild/bazel/issues/16789) with sandboxed execution and tree artifacts (which rules_js uses for the node_modules virtual store). For now it is recommended to not set `--remote_download_outputs` to either `toplevel` or `minimal` with Bazel 6.0.0rc1 & rc2. NB: `--remote_download_outputs` is also set implicitly with the [`--remote_download_minimal`](https://bazel.build/reference/command-line-reference#flag--remote_download_minimal) and [`--remote_download_toplevel`](https://bazel.build/reference/command-line-reference#flag--remote_download_toplevel) flags so these should be avoided as well until the [issue](https://github.com/bazelbuild/bazel/issues/16789) is resolved in Bazel.
> UPDATE: the [fix](https://github.com/bazelbuild/bazel/pull/16812) has landed in Bazel and you can now use `--remote_download_outputs` `toplevel` or `minimal` with Bazel `last_green`. The fix commit should be cherry-picked into the next 6.0.0rc or 6.0.0 final if that is next.
- Remote Execution (RBE) requires the latest version of Bazel, 6.0. Run `echo 6.0.0rc3 > .bazelversion` or set environment `USE_BAZEL_VERSION=6.0.0rc3`.
- `--remote_download_outputs` set to either `toplevel` or `minimal` has a regression in Bazel 6.0.0rc1 and 6.0.0rc2
due to https://github.com/bazelbuild/bazel/issues/16789. The fix is included in Bazel 6.0.0rc3.
- Building docker containers works, per [this example](https://github.com/aspect-build/rules_js/tree/main/e2e/js_image) however it requires some Starlark code which ought to be in our public API, see https://github.com/aspect-build/rules_js/issues/304
- No examples yet for stamping and publishing npm packages.
- ESM imports escape the runfiles tree and the sandbox due to https://github.com/aspect-build/rules_js/issues/362
Expand Down

0 comments on commit 8fef916

Please sign in to comment.