test(npm): add tests for odd package names (#1860)

e2e/pnpm_lockfiles/base/aliases-test.js

@@ -5,6 +5,19 @@ if (require('@aspect-test/a') !== require('@aspect-test/a2')) {
     )
 }
 
+// Various other aliases with odd scoping
+for (const pkg of [
+    '@aspect-test/a2',
+    'aspect-test-a-no-scope',
+    'aspect-test-a/no-at',
+    '@aspect-test-a-bad-scope',
+    '@aspect-test-custom-scope/a',
+]) {
+    if (require('@aspect-test/a') !== require(pkg)) {
+        throw new Error(`${pkg} should be alias of @aspect-test/a`)
+    }
+}
+
 // `alias-types-node` and `@types/node` should be importable and equal
 if (
     require('alias-types-node/package.json') !==

e2e/pnpm_lockfiles/base/package.json

@@ -4,6 +4,10 @@
     "dependencies": {
         "@aspect-test/a": "^5.0.2",
         "@aspect-test/a2": "npm:@aspect-test/a",
+        "aspect-test-a-no-scope": "npm:@aspect-test/a",
+        "aspect-test-a/no-at": "npm:@aspect-test/a",
+        "@aspect-test-a-bad-scope": "npm:@aspect-test/a",
+        "@aspect-test-custom-scope/a": "npm:@aspect-test/a",
         "@isaacs/cliui": "8.0.2",
         "debug": "ngokevin/debug#9742c5f383a6f8046241920156236ade8ec30d53",
         "hello": "https://gitpkg.vercel.app/EqualMa/gitpkg-hello/packages/hello",
@@ -20,6 +24,7 @@
         "is-odd-v2": "npm:[email protected]",
         "is-odd-v3": "npm:[email protected]",
         "uvu": "0.5.6",
+        "scoped/bad": "link:../projects/b",
         "@scoped/a": "workspace:*",
         "@scoped/b": "link:../projects/b",
         "@scoped/c": "file:../projects/c",

e2e/pnpm_lockfiles/lockfile-test.bzl

@@ -59,6 +59,10 @@ def lockfile_test(name = None):
         data = [
             ":node_modules/@aspect-test/a",
             ":node_modules/@aspect-test/a2",
+            ":node_modules/aspect-test-a-no-scope",
+            ":node_modules/aspect-test-a/no-at",
+            ":node_modules/@aspect-test-a-bad-scope",
+            ":node_modules/@aspect-test-custom-scope/a",
             ":node_modules/@types/node",
             ":node_modules/alias-only-sizzle",
             ":node_modules/alias-types-node",
@@ -80,6 +84,7 @@ def lockfile_test(name = None):
             ":node_modules",
 
             # Direct 'dependencies'
+            ":node_modules/@aspect-test",  # target for the scope
             ":node_modules/@aspect-test/a",
 
             # Direct 'devDependencies'
@@ -104,10 +109,12 @@ def lockfile_test(name = None):
             ":node_modules/@isaacs/cliui",
 
             # link:, workspace:, file:, ./rel/path
+            ":node_modules/@scoped",  # target for the scope
             ":node_modules/@scoped/a",
             ":node_modules/@scoped/b",
             ":node_modules/@scoped/c",
             ":node_modules/@scoped/d",
+            ":node_modules/scoped/bad",
 
             # Packages involving overrides
             ":node_modules/is-odd",
@@ -123,7 +130,13 @@ def lockfile_test(name = None):
             ":node_modules/@aspect-test/a2",
             # npm: alias to registry-scoped packages
             ":node_modules/alias-types-node",
-            ":node_modules/is-odd-alias",
+            # npm: alias adding/removing or odd @scopes
+            ":node_modules/aspect-test-a/no-at",
+            ":node_modules/aspect-test-a-no-scope",
+            ":node_modules/@aspect-test-a-bad-scope",
+            ":node_modules/@aspect-test-custom-scope",  # target for the scope
+            ":node_modules/@aspect-test-custom-scope/a",
+
             # npm: alias to alternate versions
             ":node_modules/is-odd-v0",
             ":node_modules/is-odd-v1",