Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not run coverage reporter if already reported #430

Merged
merged 2 commits into from
Sep 28, 2022
Merged

fix: do not run coverage reporter if already reported #430

merged 2 commits into from
Sep 28, 2022

Conversation

thesayyn
Copy link
Member

@thesayyn thesayyn commented Sep 2, 2022 •
edited
Loading

fixes #337

@thesayyn
Copy link
Member Author

thesayyn commented Sep 2, 2022

RBE failing due to bazelbuild/bazel#4685

@cgrindel
Copy link
Contributor

@thesayyn Do we need RBE to declare victory on this PR? If so, why?

@thesayyn
Copy link
Member Author

@thesayyn Do we need RBE to declare victory on this PR? If so, why?

No. just fixed the branch. It is good to go once green.

@thesayyn thesayyn enabled auto-merge (squash) September 28, 2022 15:21
gregmagolan
gregmagolan approved these changes Sep 28, 2022
View reviewed changes
Copy link
Member

@gregmagolan gregmagolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮 ^2

@thesayyn thesayyn merged commit d3adf71 into main Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregmagolan gregmagolan gregmagolan approved these changes

@jbedard jbedard Awaiting requested review from jbedard

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature request: custom coverage reporting
3 participants
@thesayyn @cgrindel @gregmagolan