Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise required Java version to 17 #239

Merged
merged 4 commits into from
Oct 14, 2024
Merged

Raise required Java version to 17 #239

merged 4 commits into from
Oct 14, 2024

Conversation

scordio
Copy link
Member

@scordio scordio commented Oct 9, 2024

Closes #194.

@scordio scordio added this to the 3.0.0 milestone Oct 9, 2024
@scordio
Copy link
Member Author

scordio commented Oct 10, 2024

Hi @Zegveld, @reitzig, @famaridon, and the rest of the AssertJ generator community.

Are you using this module directly today, or are you relying only on Maven or Gradle plugins?

If you use this directly, would you have a chance to try out this branch on your project? Feedback from a real-life project would be greatly appreciated, as I cannot yet judge whether we have enough test coverage for such a change.

@reitzig
Copy link

reitzig commented Oct 10, 2024

We are not currently using it due to the annotations issue, but we would use it through the Maven plugin.

What, specifically, would you want us to test?

cc @denniseffing @ljouon @cschwich-as

@scordio
Copy link
Member Author

scordio commented Oct 11, 2024

What, specifically, would you want us to test?

Ideally, trying out the JAR from this branch to see if it works properly in your setup.

However, as you use it through the Maven plugin, it might be cumbersome to try it out. An option could be to define the locally built JAR in the plugin's dependency section, but I haven't tried that yet.

As I plan to move the Maven plugin here and transform the project into a multi-module, you might just wait a little longer 🙂 plus, I don't intend to release 3.0.0 immediately, and we'll go with one or two milestone versions first, which will probably be the easiest option to try it out in your project.

I'll keep you posted.

@scordio scordio marked this pull request as ready for review October 12, 2024 17:14
@scordio scordio merged commit a85f106 into main Oct 14, 2024
3 of 4 checks passed
@scordio scordio deleted the java-17 branch October 14, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use @javax.annotation.processing.Generated after moving to Java 9+
2 participants