Build attestations improvements #501
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanieb
reviewed
Jan 19, 2025
| @@ -245,6 +245,12 @@ jobs: | |||
| build/pythonbuild validate-distribution ${EXTRA_ARGS} dist/*.tar.zst | |||
| - name: Generate attestations | |||
zanieb
reviewed
Jan 19, 2025
.github/workflows/release.yml
Outdated
| uses: actions/attest-build-provenance@v2 | ||
| if: ${{ github.event.inputs.dry-run == 'false' }} | ||
| with: | ||
| subject-path: dist/* |
There was a problem hiding this comment.
I'm worried about the 1024 subject limit https://github.com/actions/attest-build-provenance?tab=readme-ov-file#subject-limits
There was a problem hiding this comment.
(1131 artifacts in the last release)
There was a problem hiding this comment.
Good catch. We could arguably divide the attestation groups by python versions.
There was a problem hiding this comment.
Adjusted the glob to skip .sha256 files as I don't think they benefit from attestation. Given this purely from a count perspective we can stay within the quota ~564
Note, the glob is targeted at minimatch js library which is what actions/glob supports which this action uses underneath.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #343 (comment)