Fix ruff discovery for paths containing symbols that can't be represented by the local encoding #584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaReiser
force-pushed
the
fix-non-local-encoding-paths
branch
from
4f1d558
to
bd76273
Compare
MichaReiser
commented
Aug 15, 2024
| @@ -32,4 +39,4 @@ def find_ruff_binary_path() -> Optional[Path]: | |||
| if __name__ == "__main__": | |||
| ruff_binary_path = find_ruff_binary_path() | |||
| if ruff_binary_path: | |||
| print(os.fsdecode(str(ruff_binary_path)), flush=True) | |||
| print(os.fsdecode(ruff_binary_path), flush=True) | |||
There was a problem hiding this comment.
I think the call to str before calling os.fsdecode is just wrong? But how would I know, I don't know nothing of Python
There was a problem hiding this comment.
Yeah, I think that's correct. print(<pathlib.Path>) would use the pathlib.Path.__str__ method, so the str call here is redundant.
MichaReiser
force-pushed
the
fix-non-local-encoding-paths
branch
from
bd76273
to
df493e2
Compare
MichaReiser
force-pushed
the
fix-non-local-encoding-paths
branch
from
df493e2
to
9afc924
Compare
…nted by the local encoding
MichaReiser
force-pushed
the
fix-non-local-encoding-paths
branch
from
9afc924
to
fd7baeb
Compare
dhruvmanila
reviewed
Aug 16, 2024
Co-authored-by: Dhruv Manilawala <[email protected]>
MichaReiser
force-pushed
the
fix-non-local-encoding-paths
branch
from
86152f6
to
9590943
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #583
See inline comment for an explanation
Test Plan
löカひ漢Before fix: The python script crashed
After: It finds the right ruff binary