CONTRIBUTING: uv is now used to generate our requirements.txt files
#634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexWaygood
commented
Oct 18, 2024
Comment on lines
+38
to
+39
| - Make sure you have Python 3.7 installed | ||
| - Run `uv venv --python 3.7 && source .venv/bin/activate` to create a Python 3.7 venv and activate it. |
There was a problem hiding this comment.
Unfortunately uv will not install Python 3.7 for you if you don't have it already installed; 3.7 is too old for uv
There was a problem hiding this comment.
Ah yeah, I remember facing this
There was a problem hiding this comment.
I think Python is only required to bundle ruff-lsp so it should be fine
There was a problem hiding this comment.
Python 3.7 is also still installable by other means, so it's "okay", just makes it a bit more annoying to work with if you don't already have Python 3.7 installed locally. Luckily I do 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan