is_subclass_of should not respect Any/Unknown in bases

astral-sh · Oct 18, 2024 · 985b235 · 985b235
1 parent 3365566
commit 985b235
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/crates/red_knot_python_semantic/resources/mdtest/binary/instances.md b/crates/red_knot_python_semantic/resources/mdtest/binary/instances.md
@@ -302,7 +302,7 @@ class Y(Foo):
     pass
 
 # TODO: Should be `int | Unknown`; see above discussion.
-reveal_type(X() + Y())  # revealed: Unknown
+reveal_type(X() + Y())  # revealed: int
 ```
 
 ## Unsupported

diff --git a/crates/red_knot_python_semantic/src/types.rs b/crates/red_knot_python_semantic/src/types.rs
@@ -1446,7 +1446,9 @@ impl<'db> ClassType<'db> {
         (other == self)
             || self.bases(db).any(|base| match base {
                 Type::Class(base_class) => base_class == other,
-                Type::Any | Type::Unknown => true,
+                // `is_subclass_of` is checking the subtype relation, in which gradual types do not
+                // participate, so we should not return `True` if we find `Any/Unknown` in the
+                // bases.
                 _ => false,
             })
     }