Update riscv64 Python downloads to allow install on riscv64gc (#1…

…0937) Closes #10883
astral-sh · Jan 24, 2025 · eeab865 · eeab865
1 parent 98e7cd0
commit eeab865
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 9 deletions.
diff --git a/crates/uv-python/src/downloads.inc b/crates/uv-python/src/downloads.inc
@@ -124,7 +124,7 @@ pub(crate) const PYTHON_DOWNLOADS: &[ManagedPythonDownload] = &[
             prerelease: Some(Prerelease { kind: PrereleaseKind::Alpha, number: 4 }),
             implementation: LenientImplementationName::Known(ImplementationName::CPython),
             arch: Arch{
-                family: target_lexicon::Architecture::Riscv64(target_lexicon::Riscv64Architecture::Riscv64),
+                family: target_lexicon::Architecture::Riscv64(target_lexicon::Riscv64Architecture::Riscv64gc),
                 variant: None,
             },
             os: Os(target_lexicon::OperatingSystem::Linux),
@@ -376,7 +376,7 @@ pub(crate) const PYTHON_DOWNLOADS: &[ManagedPythonDownload] = &[
             prerelease: Some(Prerelease { kind: PrereleaseKind::Alpha, number: 4 }),
             implementation: LenientImplementationName::Known(ImplementationName::CPython),
             arch: Arch{
-                family: target_lexicon::Architecture::Riscv64(target_lexicon::Riscv64Architecture::Riscv64),
+                family: target_lexicon::Architecture::Riscv64(target_lexicon::Riscv64Architecture::Riscv64gc),
                 variant: None,
             },
             os: Os(target_lexicon::OperatingSystem::Linux),
@@ -1024,7 +1024,7 @@ pub(crate) const PYTHON_DOWNLOADS: &[ManagedPythonDownload] = &[
             prerelease: None,
             implementation: LenientImplementationName::Known(ImplementationName::CPython),
             arch: Arch{
-                family: target_lexicon::Architecture::Riscv64(target_lexicon::Riscv64Architecture::Riscv64),
+                family: target_lexicon::Architecture::Riscv64(target_lexicon::Riscv64Architecture::Riscv64gc),
                 variant: None,
             },
             os: Os(target_lexicon::OperatingSystem::Linux),
@@ -1348,7 +1348,7 @@ pub(crate) const PYTHON_DOWNLOADS: &[ManagedPythonDownload] = &[
             prerelease: None,
             implementation: LenientImplementationName::Known(ImplementationName::CPython),
             arch: Arch{
-                family: target_lexicon::Architecture::Riscv64(target_lexicon::Riscv64Architecture::Riscv64),
+                family: target_lexicon::Architecture::Riscv64(target_lexicon::Riscv64Architecture::Riscv64gc),
                 variant: None,
             },
             os: Os(target_lexicon::OperatingSystem::Linux),
@@ -2752,7 +2752,7 @@ pub(crate) const PYTHON_DOWNLOADS: &[ManagedPythonDownload] = &[
             prerelease: None,
             implementation: LenientImplementationName::Known(ImplementationName::CPython),
             arch: Arch{
-                family: target_lexicon::Architecture::Riscv64(target_lexicon::Riscv64Architecture::Riscv64),
+                family: target_lexicon::Architecture::Riscv64(target_lexicon::Riscv64Architecture::Riscv64gc),
                 variant: None,
             },
             os: Os(target_lexicon::OperatingSystem::Linux),
@@ -5416,7 +5416,7 @@ pub(crate) const PYTHON_DOWNLOADS: &[ManagedPythonDownload] = &[
             prerelease: None,
             implementation: LenientImplementationName::Known(ImplementationName::CPython),
             arch: Arch{
-                family: target_lexicon::Architecture::Riscv64(target_lexicon::Riscv64Architecture::Riscv64),
+                family: target_lexicon::Architecture::Riscv64(target_lexicon::Riscv64Architecture::Riscv64gc),
                 variant: None,
             },
             os: Os(target_lexicon::OperatingSystem::Linux),
@@ -8260,7 +8260,7 @@ pub(crate) const PYTHON_DOWNLOADS: &[ManagedPythonDownload] = &[
             prerelease: None,
             implementation: LenientImplementationName::Known(ImplementationName::CPython),
             arch: Arch{
-                family: target_lexicon::Architecture::Riscv64(target_lexicon::Riscv64Architecture::Riscv64),
+                family: target_lexicon::Architecture::Riscv64(target_lexicon::Riscv64Architecture::Riscv64gc),
                 variant: None,
             },
             os: Os(target_lexicon::OperatingSystem::Linux),
@@ -12202,7 +12202,7 @@ pub(crate) const PYTHON_DOWNLOADS: &[ManagedPythonDownload] = &[
             prerelease: None,
             implementation: LenientImplementationName::Known(ImplementationName::CPython),
             arch: Arch{
-                family: target_lexicon::Architecture::Riscv64(target_lexicon::Riscv64Architecture::Riscv64),
+                family: target_lexicon::Architecture::Riscv64(target_lexicon::Riscv64Architecture::Riscv64gc),
                 variant: None,
             },
             os: Os(target_lexicon::OperatingSystem::Linux),

diff --git a/crates/uv-python/template-download-metadata.py b/crates/uv-python/template-download-metadata.py
@@ -74,7 +74,10 @@ def prepare_arch(arch: dict) -> tuple[str, str]:
         case "armv7":
             family = "Arm(target_lexicon::ArmArchitecture::Armv7)"
         case "riscv64":
-            family = "Riscv64(target_lexicon::Riscv64Architecture::Riscv64)"
+            # The `gc` variant of riscv64 is the common base instruction set and
+            # is the target in `python-build-standalone`
+            # See https://github.com/astral-sh/python-build-standalone/issues/504
+            family = "Riscv64(target_lexicon::Riscv64Architecture::Riscv64gc)"
         case value:
             family = value.capitalize()
     variant = (