feat: add domain routing hook #38
Conversation
|
Hi, can you add some test coverage for your contract, please ? You can deploy your contract by defining a function in the setup.cairo (cf: https://github.com/astraly-labs/hyperlane_starknet/blob/main/contracts/src/tests/setup.cairo). You can use |
|
@JordyRo1 Tried to add tests. Can you have a look now |
| } | ||
|
|
||
| fn post_dispatch(ref self: ContractState, _metadata: Bytes, _message: Message) { | ||
| self._get_configured_hook(_message.clone()).post_dispatch(_metadata, _message); |
There was a problem hiding this comment.
The post dispatch function lacks the fee mecanism (represented on the solidity version by msg.value). Since we do not have native token, we will have to transfer erc20 manually. Leave it as it is right, now, I will handle it.
There was a problem hiding this comment.
I can try to add the fee mechanism. Context would be the protocol_fee hook? Additionally, did you have a look at my test files
There was a problem hiding this comment.
Yes, protocol fee hook is the context and since it is a routing hook, it will require to quote_dispatch.
| let ownable = IOwnableDispatcher { contract_address: set_routing_hook_addrs.contract_address }; | ||
| start_prank(CheatTarget::One(ownable.contract_address), OWNER()); | ||
| let destination: u32 = 18; | ||
| let hook: ContractAddress = setup_mock_hook().contract_address; |
There was a problem hiding this comment.
The errror Result: unwrap failed comes from this setup_mock_hook. Since we already declared the setup_mock_hook for the mailbox setup, calling it again here cause the declaration to fail because the contract is already declared
| let token_dispatcher = IERC20Dispatcher { contract_address: self.fee_token.read() }; | ||
| let user_balance = token_dispatcher.balance_of(from); | ||
| assert(user_balance >= amount, Errors::INSUFFICIENT_BALANCE); | ||
| let transfer_flag: bool = token_dispatcher.transfer_from(from, to, amount); |
There was a problem hiding this comment.
Can you check the allowance for the caller before the transfer
|
Reviewed. The general hook idea is understood, everything seems fine ! |
Implements #29