fix: defaulted l1 gas price in devnet mode (madara-alliance#265)

astraly-labs · Sep 16, 2024 · 0ac1f62 · 0ac1f62
1 parent 4aa6b42
commit 0ac1f62
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 2 deletions.
diff --git a/.github/workflows/coverage.yml b/.github/workflows/coverage.yml
@@ -48,4 +48,4 @@ jobs:
         uses: coverallsapp/github-action@v2
         with:
           files: lcov.info
-          debug: true
+          debug: true
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,7 @@
 
 ## Next release
 
+- fix: defaulted l1 gas price in devnet mode
 - fix: fixed anvil port value in tests
 - ci: add coveralls report
 - test: added tests for declare and deploy transactions

diff --git a/crates/node/src/cli/l1.rs b/crates/node/src/cli/l1.rs
@@ -12,7 +12,7 @@ pub struct L1SyncParams {
     pub sync_l1_disabled: bool,
 
     /// The L1 rpc endpoint url for state verification.
-    #[clap(long, value_parser = parse_url, value_name = "ETHEREUM RPC URL", required_unless_present = "sync_l1_disabled")]
+    #[clap(long, value_parser = parse_url, value_name = "ETHEREUM RPC URL")]
     pub l1_endpoint: Option<Url>,
 
     /// Disable the gas price sync service. The sync service is responsible to fetch the fee history from the ethereum.

diff --git a/crates/node/src/main.rs b/crates/node/src/main.rs
@@ -76,6 +76,10 @@ async fn main() -> anyhow::Result<()> {
 
     let l1_gas_setter = GasPriceProvider::new();
     let l1_data_provider: Arc<dyn L1DataProvider> = Arc::new(l1_gas_setter.clone());
+    if run_cmd.block_production_params.devnet {
+        run_cmd.l1_sync_params.sync_l1_disabled = true;
+        run_cmd.l1_sync_params.gas_price_sync_disabled = true;
+    }
 
     let l1_service = L1SyncService::new(
         &run_cmd.l1_sync_params,