Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added routing for onchain history #112

Merged
merged 10 commits into from
Aug 9, 2024
Merged

Conversation

akhercha
Copy link
Member

@akhercha akhercha commented Aug 9, 2024

Resolves: #111

Work done

  • Added routing for onchain historical entries.

Did not do

  • Refactored errors, some errors are confusing. This should be addressed in a follow-up PR, see dev: better errors #35
  • Merged the routing code with the offchain entry because we do not have proper tests - let's not break something and refactor that later.
  • Tests, will implement that in a follow up PR when I'm back from holidays (so the feature is usable for now before I leave), see test: onchain/get_history E2E tests #117

@akhercha akhercha self-assigned this Aug 9, 2024
@akhercha akhercha requested a review from EvolveArt August 9, 2024 08:43
@EvolveArt EvolveArt merged commit c4d74e1 into main Aug 9, 2024
6 checks passed
@EvolveArt EvolveArt deleted the feat/history_routing branch August 9, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dev: add routing for /history endpoint
2 participants