Relocate Cometbft Initialization #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steezeburger
approved these changes
Mar 25, 2024
steezeburger
added a commit
that referenced
this pull request
Mar 26, 2024
* add version cmd, ignore bin dir * add init command, embed all config, started on binary download * output path for downloaded binaries ignored * working downloading and file extraction * added mprocs config as a stop gap, readme * small readme updates, skip download if bin already present * use localized data dir for sequencer and cometbft data * added run command, renamed bin to astria-dev * readme updates, run cmd init checking print improvements * typo fix * readme updates * revert module naming * reorg of commands to be sub commands of dev * move embedded files to config dir * status prints added to embedded file recreation * conditional compilation for different os and arch * removed just and mprocs deps * add run check for rollup rpc port for composer * small error print and readme updates * cleanup of initialize check, added linux support * add fmt to justfile * default dir changed to ~/.astria * env cleanup * force stdout for sequencer * initial tview ui * add default just command * added running cometbft to tview ui * added conductor and composer to tview ui * cmd definitions moved outside of go routines to allow for sigint capture * removed sleeps, added channel waits * added clean cmd for removing local cometbft and sequencer data * added clear all command * added word wrap and removal of ansi escape characters view toggle * remove testing text color print * ansi escape character now parsed * cleanup and comment updates * added basic help bar at bottom * added ability to select app and jump in and out of fullscreen * prevent focus change when in fullscreen * typo fixes * update just commands * readme updates, disable completion command * small readme update, added fullscreen specific help bar * added arrow key and mouse scrolling to fullscreen view * updates to autoscroll setting, add stderr capture to sequencer * cleaned up appendText function, updated justfile to capture tview logs, added pskill command to justfile * add stderr capture to output * justfile comments * App and ProcessRunner structs * todo * settings status display updated, added basic help page * filled out main help page * action keys are no longer case sensitive * added more to help window * added boarderless logs option * fixed border typo * comment * slight reorg. comments. * refactor processrunner. contexts. * getters * SetInputCapture, stop, word wrap * keyboard shortcuts for selecting panes, fullscreen, exit * comment * more clear pattern for ui state * autoscroll and notes * comments. cruft. * words * add command for sequencer create account (#6) * add command for sequencer create account * name devtools package * move error handling to command code. test. * descriptions and comment cleanup. * justfile help docstrings. test command. * remove autocorrect fail * add github action to test go code * remove cruft * Feature: gh actions (#2) * gh actions * fix github actions * fix package name * Feat/adds tests (#9) * add "t" as alias for "test" in justfile * refactor to be more testable. ProcessRunner interface and mock. * "pscheck" just command to check for leftover astria processes * more tests * merge main * cleanup func. doc comment. * move version to root of cmd * reorganize clean command * naming conventions * Relocate Cometbft Initialization (#10) * moved cometbft setup from run cmd to init cmd * fmt.Println formating fix * added borderless logs toggle when in full screen * added borderless logs toggle when in full screen (#16) --------- Co-authored-by: Sam Bukowski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the
comtbft initcommand was getting run right before starting the Cometbft binary within thedev runcommand.This was unnecessary, and the initialization of Cometbft has been moved to the
dev initcommand.