feat(conductor, proto): include celestia height in firm blocks #1052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joroshiba
force-pushed
the
joroshiba/add-cel-height
branch
from
d03ebf1
to
1c866ee
Compare
SuperFluffy
reviewed
May 28, 2024
| // The next sequencer block height which can be executed. | ||
| uint32 next_sequencer_height = 3; | ||
| // The lowest celestia block height which can be used for next finalization. | ||
| uint32 base_celestia_height = 4; |
There was a problem hiding this comment.
Pretty verbose, but IMO clearer
Suggested change
| uint32 base_celestia_height = 4; | |
| uint32 celestia_height_of_last_firm_commitment = 4; |
EDIT: Ah, I see. With removal of celestia_base_block_height from genesis the rollup node must provide this with its initial commitment state.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Brief summary of the changes made, ie "what?"
Background
Brief background on why these changes were made, ie "why?"
Changes
Testing
How are these changes tested?
Metrics
Breaking Changelist
Related Issues
Link any issues that are related, prefer full github links.
closes