tests(sequencer): add snapshot tests for app hash #1057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fraser999
approved these changes
May 9, 2024
|
@Fraser999 ended up adding a snapshot test which tests every action! |
joroshiba
approved these changes
May 10, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
…ria into noot/breaking-changes-test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
add snapshot tests for app hash to catch breaking changes made to the app logic.
Background
if changes are breaking, we should know about it. these tests should catch (most) breaking changes to the application state itself.
Changes
init_chain,finalize_block, and all actions except for IBC actions as they require extensive setup.Testing
no code was changed, just tests added
Related Issues
closes #1051